[JDBC 라이브러리 구현하기 - 3,4단계] 케로(김지현) 미션 제출합니다. #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujamint
approved these changes
Oct 12, 2023
| public void insert(final User user) { | ||
| transactionTemplate.execute(() -> { | ||
| userService.insert(user); | ||
| return null; |
There was a problem hiding this comment.
void 메서드마다 null을 반환하는 것이 불편하다면, TransactionTemplate에 void 타입을 반환하는 메서드를 하나 더 만들어도 좋을 거 같아요!
There was a problem hiding this comment.
그런 방법이 있군여...!!!
수정해보도록 하겠습니다 감사합니다 !!!
| throw new DataAccessException(e); | ||
| } finally { | ||
| turnOnAutoCommit(connection); | ||
| DataSourceUtils.releaseConnection(connection, dataSource); |
There was a problem hiding this comment.
현재 DataSourceUtils.releaseConnection()은 autoCommit 모드일 때만 Connection을 닫아주는 것으로 보여요! 그렇다면 트랜잭션을 실행한 Connection은 autoCommit이 false이기 때문에 계속 닫히지 않을 거 같아요.
혹시 제가 놓친 부분이 있는 걸까요?!
There was a problem hiding this comment.
finally문 안에서 conncetion을 unbine하기 전에 turnOnAutoCommit() 메서드를 이용하여 오토커밋을 다시 켜주어 DataSourceUtils 에서 판단 할 수 있도록 하려 했는데,,,
실수로 turnOnAutoCommit()메서드의 구현을 잘못한 것 같습니다,,,
짚어주셔서 감사합니다 !!!
| return executeQuery(sql, PreparedStatement::executeUpdate, parameters); | ||
| } | ||
|
|
||
| private <T> T executeQuery(final String sql, final PreparedStateExecutor<T> executor, final Object... parameters) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 민트...
어제도 심신이 옳지 못한 관계로 오늘 제출합니다....ㅜㅜ
편의 봐주셔서 감사합니다...ㅜㅜ
지난 리뷰에서 마음 깊이 이해했지만 시간관계상 반영하지 못한 부분이 몇 있습니다...
2단계 답변
3단계
4단계