[JDBC 라이브러리 구현하기 - 4단계] 홍고(홍여진) 미션 제출합니다. #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitchannn
approved these changes
Oct 11, 2023
|
|
||
| @Override | ||
| public User findById(long id) { | ||
| return transactionManager.execute(() -> userService.findById(id)); |
| public class TxUserService implements UserService { | ||
|
|
||
| private final UserService userService; | ||
| private final TransactionManager transactionManager; |
| final PreparedStatement preparedStatement = connection.prepareStatement(sql) | ||
| final Connection connection = DataSourceUtils.getConnection(dataSource); | ||
| try ( | ||
| final PreparedStatement preparedStatement = connection.prepareStatement(sql) |
There was a problem hiding this comment.
트랜잭션을 통하지 않고 JdbcTemplate 코드를 직접 실행하는 경우에 커넥션이 닫히지 않는 문제가 발생할 것 같은데요!
이거에 대한 홍고의 생각이 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요, 깃짱!
마지막 4단계입니다ㅠㅠ
이번에도 리뷰 잘 부탁드립니다! 🙇♂️🙇♀️