[JDBC 라이브러리 구현하기 - 4단계] 마코(이규성) 미션 제출합니다. #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splitCoding
requested changes
Oct 11, 2023
Comment on lines
34
to
57
| public void changePassword(final long id, final String newPassword, final String createBy) { | ||
| final var user = findById(id); | ||
| user.changePassword(newPassword); | ||
|
|
||
| final var dataSource = DataSourceConfig.getInstance(); | ||
| final var connection = DataSourceUtils.getConnection(dataSource); | ||
| try { | ||
| connection.setAutoCommit(false); | ||
|
|
||
| userDao.update(user); | ||
| userHistoryDao.log(new UserHistory(user, createBy)); | ||
|
|
||
| connection.commit(); | ||
| } catch (SQLException e) { | ||
| try { | ||
| connection.rollback(); | ||
| throw new DataAccessException(e); | ||
| } catch (SQLException e2) { | ||
| throw new DataAccessException(e2); | ||
| } | ||
| } finally { | ||
| DataSourceUtils.releaseConnection(dataSource); | ||
| } | ||
| } |
There was a problem hiding this comment.
요구사항인 인터페이스를 활용하여 트랜잭션 서비스를 추상화하여 비즈니스 로직과 데이터 액세스 로직을 분리해보자. 가 지켜지지 않은 것 같아요!!😭
( 데이터 액세스 로직을 해당 TransactionTemplate 에서 이미 다 처리하셨는데 아마 기조 로직을 삭제하지 않으신것 같아요ㅎㅎ )
There was a problem hiding this comment.
TxUserService는 트랜잭션을 사용하고, AppUserService는 트랜잭션을 사용하지 않는건데 트랜잭션 코드가 남아있었네요ㅎㅎ 지워줬습니다!
Comment on lines
+15
to
+33
| public static void execute(Runnable transactionCallback, DataSource dataSource) { | ||
| final var connection = DataSourceUtils.getConnection(dataSource); | ||
| try { | ||
| connection.setAutoCommit(false); | ||
|
|
||
| transactionCallback.run(); | ||
|
|
||
| connection.commit(); | ||
| } catch (SQLException e) { | ||
| try { | ||
| connection.rollback(); | ||
| throw new DataAccessException(e); | ||
| } catch (SQLException e2) { | ||
| throw new DataAccessException(e2); | ||
| } | ||
| } finally { | ||
| DataSourceUtils.releaseConnection(dataSource); | ||
| } | ||
| } |
There was a problem hiding this comment.
여기에서도 템플릿 콜팩 패턴 사용!!!👍 매우 좋은 방법인 것 같아요!!!😊
|
레거시가 남아있었군요ㅎㅎㅎㅎ |
|
코드가 깔끔해서 리뷰 내내 항상 보기 편했어요!!😊 |
splitCoding
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 스플릿!
트랜잭션 동기화는 이전 단계에서 이미 수행해서 트랜잭션 서비스 추상화만 구현했습니다!
jdbc 모듈에 TransactionTemplate을 만들어서 트랜잭션 관련 템플릿을 구현하고 콜백을 받아 트랜잭션을 수행하도록 했습니다.
이번 리뷰도 잘 부탁드립니다~