[JDBC 라이브러리 구현하기 - 4단계] 엔초(권예진) 미션 제출합니다. #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…동일한 커넥션을 사용할 수 있도록 기능 추가
jaehee329
approved these changes
Oct 10, 2023
| try { | ||
| connection.setAutoCommit(false); | ||
| log.info("transaction start"); | ||
| public void execute(Runnable action) { |
There was a problem hiding this comment.
저도 제 리뷰어의 꼼꼼함 덕분에 알게 되었는데요, Runnable 인터페이스의 JavaDoc을 읽으면 다음의 내용이 있더라구요!
The Runnable interface should be implemented by any class whose instances are intended to be executed by a thread. The class must define a method of no arguments called run.
https://docs.oracle.com/javase/8/docs/api/java/lang/Runnable.html
추가적인 내용까지 간단히 해석해보았을 때 Runnable을 구현해 넘겨주는 곳에서는 해당 콜백 함수가 원 쓰레드의 작업과 별개의 쓰레드에서 실행되는 것을 사용 목표로 한다고 합니다!
저도 이 내용을 찾아본 뒤에 직접 만든 함수형 인터페이스를 사용하도록 변경했는데 엔초도 참고하시면 좋을 것 같아요!
Comment on lines
+54
to
+58
| private void transactionStart() throws SQLException { | ||
| this.connection = DataSourceUtils.getConnection(dataSource); | ||
| connection.setAutoCommit(false); | ||
| log.info("transaction start"); | ||
| } |
There was a problem hiding this comment.
트랜잭션 관련 내용을 메서드로 분리하니 사용처가 훨씬 간소화되고 좋네요 😊
Comment on lines
+33
to
+35
| } finally { | ||
| DataSourceUtils.releaseTransactionConnection(connection, dataSource); | ||
| } |
There was a problem hiding this comment.
DataSourceUtils를 사용한 connection 해제 로직 잘 추가해주셨네요~😁
|
이전 단계에 대해 말씀주신 것은 해당 PR에 댓글 남겼습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 모디!
4단계 구현 완료했습니다~
3단계 리뷰에서 질문 주신 부분에 대해서는 해당 pr에 답을 달아놓았습니다. 아래 토글에 사진도 첨부해 놓았으니 답변 확인만 하실 거라면 사진으로 보셔도 될 것 같습니다. pr 바로가기
사진
마지막 리뷰도 잘 부탁드립니다~