[JDBC 라이브러리 구현하기 - 4단계] 로지(윤가영) 미션 제출합니다. #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjooon2
requested changes
Oct 10, 2023
Comment on lines
18
to
20
| if (dataSourceConnectionMap == null) { | ||
| return null; | ||
| } |
Comment on lines
+93
to
97
| final Connection conn = getConnection(); | ||
| try (final PreparedStatement preparedStatement = conn.prepareStatement(sql)) { | ||
| log.debug("query : {}", sql); | ||
|
|
||
| setParameters(preparedStatement, parameters); |
There was a problem hiding this comment.
TxUserService가 아닌 jdbctemplate을 바로 사용한다면 connection이 닫히지 않을 것 같습니다...!
Comment on lines
29
to
45
| final var dataSource = DataSourceConfig.getInstance(); | ||
| final var connection = DataSourceUtils.getConnection(dataSource); | ||
| try { | ||
| connection.setAutoCommit(false); | ||
| userService.changePassword(id, newPassword, createBy); | ||
|
|
||
| connection.commit(); | ||
| } catch (final Exception e) { | ||
| try { | ||
| connection.rollback(); | ||
| } catch (SQLException ex) { | ||
| throw new DataAccessException(ex); | ||
| } | ||
| throw new DataAccessException(e); | ||
| } finally { | ||
| DataSourceUtils.releaseConnection(connection, dataSource); | ||
| } |
There was a problem hiding this comment.
조금 더 챌린지 하실게 필요하시다면
트랜잭션 부분만 transactionTemplate으로 추상화하는 것은 어떨까요?
iamjooon2
approved these changes
Oct 12, 2023
Comment on lines
+23
to
+26
| execute(DataSourceConfig.getInstance(), () -> { | ||
| userService.insert(user); | ||
| return null; | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 가비 ^^~
4단계를 한번 구현해보았습니다.
저는 구현하다 막판에 고민되는 점이 하나 있었는데요,
TxUserService에서의 트랜잭션 경계 부분 말이죠
예시코드에서
다음과 같이 finally 부분에서 TransactionSynchronizationManaber 의 unbindResource(dataSource); 를 해주는 게 살짝 이해가 되지 않았어요.
왜냐하면 TransactionSynchronizationManager의 bindResource는 TxUserService가 아닌 DataSourceUtils에서 호출해주고 있었기 때문이에요.
그래서 unbind 해주는 것도 제가 생각했을 때는 TransactionSynchronizationManager에서 해주는게 맞다고 생각했어요.
저는 제가 말한 방식으로 구현했는데 문제는 찾지 못했습니다. 가비는 어떻게 생각하나요?