[JDBC 라이브러리 구현하기 - 4단계] 매튜(김재연) 미션 제출합니다. #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aak2075
requested changes
Oct 9, 2023
| PreparedStatementCreator preparedStatementCreator = new PreparedStatementCreator(sql); | ||
| PreparedStatementSetter preparedStatementSetter = new PreparedStatementSetter(parameters); | ||
| Connection connection = DataSourceUtils.getConnection(dataSource); |
There was a problem hiding this comment.
TransactionExecutor를 사용하지 않고 직접 update나 다른 Jdbctemplate의 메서드를 호출하는 경우에는 Connection이 닫히지 않겠군요!
| @@ -15,6 +15,8 @@ dependencies { | |||
| implementation "org.apache.commons:commons-lang3:3.13.0" | |||
| implementation "ch.qos.logback:logback-classic:1.2.12" | |||
|
|
|||
| implementation "com.h2database:h2:2.2.220" | |||
There was a problem hiding this comment.
DataSourceConfig 를 jdbc 모듈에 옮겨서용!
|
|
||
| DatabasePopulatorUtils.execute(DataSourceConfig.getInstance()); | ||
| final var user = new User("gugu", "password", "[email protected]"); | ||
| userService.insert(user); | ||
| userDao.insert(user); |
| private TransactionExecutor() { | ||
| } | ||
|
|
||
| public static void transactionCommand(Runnable runnable) { |
|
|
||
| public abstract class TransactionSynchronizationManager { | ||
|
|
||
| private static final ThreadLocal<Map<DataSource, Connection>> resources = new ThreadLocal<>(); | ||
| private static final ThreadLocal<Map<DataSource, Connection>> resources = ThreadLocal.withInitial(HashMap::new); |
|
|
||
| connection.commit(); | ||
| } catch (SQLException firstException) { | ||
| rollback(); |
There was a problem hiding this comment.
메서드로 깔끔하게 분리해 주셨군요. 멋져요.
다만, exception 변수명을 firstException, rollback 메서드 내에서는 secondException으로 사용하고 있는데요, 첫번째인지 두번째인지는 몰라도 괜찮지 않을까요?
|
마! 규성씨! 제가 말씀하신 사항들을 잘 이행한지는 모르곘지만, 최대한 반영해보려 노력했습니다! 이번에도 잘 부탁드립니다! |
aak2075
approved these changes
Oct 10, 2023
|
떼이이이잉... 그렇군요... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 마! 규성씨
저번 피드백도 너무 꿀맛이었습니다!
역시 마! 규성씨는 다르군요.
이번 PR 은 저번 PR 과 비교 하였을 때 크게 변동사항이 없는 것 같아요.
조금 있다면 DataSourceUtils 를 구현하여 사용한 것과, UserService 를 추상화한 것?
그 정도인 것 같네요 ㅎㅎ
마지막으로 이번 리뷰도 잘 부탁드린다는 말 전하면서 물러나도록 하겠습니다.
이번에도 잘 부탁드립니다 기무사 출신 스파이 마! 규성씨~!