[JDBC 라이브러리 구현하기 - 1단계] 로이스(원태연) 미션 제출합니다. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjdtls690
approved these changes
Sep 29, 2023
| } | ||
| } | ||
|
|
||
| private void setAllArguments(final Object[] args, final PreparedStatement preparedStatement) throws SQLException { |
There was a problem hiding this comment.
전 개인적으로 여러 메서드에서 공용으로 쓰이는 setAllArguments 메서드 같은 경우는 가장 아래쪽에 메서드를 배치하는 편인데, 로이스는 처음으로 호출된 메서드 바로 밑에 두시나보군요. 어떤 기준이 있는 것인지 궁금하네요!
| } | ||
|
|
||
| public List<User> findAll() { | ||
| // todo | ||
| return null; | ||
| final var sql = "select id, account, password, email from users"; |
There was a problem hiding this comment.
var를 쓰시면서 로이스가 체감한 장단점이 있다면 어떤 것들이 있을 지 궁금합니다 :)
TaeyeonRoyce
added a commit
to TaeyeonRoyce/jwp-dashboard-jdbc
that referenced
this pull request
Oct 2, 2023
* 패키지 위치 변경 및 코드 정리 * 패키지 위치 변경 및 코드 정리 * 패키지 위치 변경 및 코드 정리 * feat: JdbcTemplate update 메서드 추가 * test: UserHistory log 테스트 추가 * refactor: 이전 버전 Insert 제거 * feat: RowMapper 추가 * feat: 단일 객체 조회(queryForObject) 추가 * feat: findByAccount 추가 * feat: findAll 추가 * feat: update 추가 * style: 불필요한 import 제거 --------- Co-authored-by: kang-hyungu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요, 아벨. 페어 이후 오랜만에 뵙네요!
JdbcTemplate을 통해 UserDao에서 중복되는 코드를 옮겨보았습니다.이번 리뷰 요청 범위입니다! 커밋s
리뷰 잘 부탁드려요!