Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1단계 - JDBC 라이브러리 구현하기] 베베(최원용) 미션 제출합니다. #264

Merged
merged 10 commits into from
Sep 28, 2023
Merged

[1단계 - JDBC 라이브러리 구현하기] 베베(최원용) 미션 제출합니다. #264

merged 10 commits into from
Sep 28, 2023

Conversation

wonyongChoi05
Copy link
Member

@wonyongChoi05 wonyongChoi05 commented Sep 26, 2023 •
edited
Loading

안녕하세요 후후추추~ 일단 제가 이해한대로 진행해봤는데 리뷰 잘 부탁드립니다 ㅎㅎ

Combi153
Combi153 approved these changes Sep 28, 2023
View reviewed changes
Copy link

@Combi153 Combi153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 베베 😀

추석 연휴 잘 보내고 계신가요?

할머니댁에서 맥북 켜고 리뷰하는 기분은 묘하네요. TMI 입니다 ㅎㅎ

PR을 굉장히 빨리 보내셨는데 코드 작성의 속도와 퀄리티가 정말 대단하세요 👍

코드가 전체적으로 깔끔하고, 요구사항도 모두 만족한 것 같아서 바로 머지할게요!

다만 코드를 읽다보니 궁금한 사항이 많이 생겨서 물음표 살인마? 가 되었습니다

베베의 답변을 기다릴게요!

1단계 고생하셨습니다 👋

study/src/test/java/connectionpool/stage1/Stage1Test.java Outdated Show resolved Hide resolved
app/src/main/java/com/techcourse/dao/UserDao.java Outdated Show resolved Hide resolved
jdbc/src/main/java/org/springframework/jdbc/core/RowMapper.java Show resolved Hide resolved
app/src/main/java/com/techcourse/dao/UserDao.java Outdated Show resolved Hide resolved
app/src/main/java/com/techcourse/AppWebApplicationInitializer.java Outdated Show resolved Hide resolved
app/src/main/java/com/techcourse/dao/UserDaoImpl.java Show resolved Hide resolved
jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java Show resolved Hide resolved
jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateTest.java Show resolved Hide resolved
app/src/main/java/com/techcourse/dao/UserDaoImpl.java Show resolved Hide resolved
@Combi153 Combi153 merged commit 9e37a2e into woowacourse:wonyongchoi05 Sep 28, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Combi153 Combi153 Combi153 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wonyongChoi05 @Combi153 @kang-hyungu