fix: TransactionSynchronizationManager 트랜잭션 활성화 여부 테스트 오류 수정

woowacourse · Oct 10, 2023 · 6fb201c · 6fb201c
1 parent da18ff9
commit 6fb201c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.../main/java/org/springframework/transaction/support/TransactionSynchronizationManager.java b/.../main/java/org/springframework/transaction/support/TransactionSynchronizationManager.java
@@ -32,7 +32,7 @@ public static Connection unbindResource(final DataSource key) {
 
     public static boolean isTransactionActive(final DataSource dataSource) {
         try {
-            return resources.get().get(dataSource).getAutoCommit();
+            return !resources.get().get(dataSource).getAutoCommit();
         } catch (final SQLException e) {
             throw new TransactionSynchronizationManagerException(e);
         }

diff --git a/...t/java/org/springframework/transaction/support/TransactionSynchronizationManagerTest.java b/...t/java/org/springframework/transaction/support/TransactionSynchronizationManagerTest.java
@@ -65,15 +65,24 @@ class IsTransactionActive {
         @DisplayName("실행한 경우")
         void trueCase() throws SQLException {
             final DataSource datasource = getInstance();
-            TransactionSynchronizationManager.bindResource(datasource, datasource.getConnection());
+            final Connection connection = datasource.getConnection();
+            connection.setAutoCommit(false);
+
+            TransactionSynchronizationManager.bindResource(datasource, connection);
 
             assertTrue(isTransactionActive(getInstance()));
+            connection.close();
         }
 
         @Test
         @DisplayName("실행하지 않은 경우")
         void falseCase() throws SQLException {
+            final DataSource datasource = getInstance();
+            final Connection connection = datasource.getConnection();
+            TransactionSynchronizationManager.bindResource(datasource, connection);
+
             assertFalse(isTransactionActive(getInstance()));
+            connection.close();
         }
     }