refactor: 중복 코드 제거

woowacourse · Oct 11, 2023 · 6d05798 · 6d05798
1 parent 237a3a3
commit 6d05798
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/jdbc/src/main/java/org/springframework/transaction/support/TransactionManager.java b/jdbc/src/main/java/org/springframework/transaction/support/TransactionManager.java
@@ -25,7 +25,7 @@ public void execute(final Runnable logicExecutor) {
 
     public <T> T executeWithResult(final Supplier<T> logicExecutor) {
         final Connection conn = DataSourceUtils.getConnection(dataSource);
-        setTransactionActive(conn);
+        setTransactionActiveStatus(conn, true);
         try {
             conn.setAutoCommit(false);
             T result = logicExecutor.get();
@@ -35,20 +35,14 @@ public <T> T executeWithResult(final Supplier<T> logicExecutor) {
             rollback(conn);
             throw new TransactionException(e);
         } finally {
-            setTransactionInactive(conn);
+            setTransactionActiveStatus(conn, false);
             DataSourceUtils.releaseConnection(conn, dataSource);
         }
     }
 
-    private void setTransactionActive(final Connection conn) {
+    private void setTransactionActiveStatus(final Connection conn, final boolean isTransactionActive) {
         ConnectionHolder connectionHolder = new ConnectionHolder(conn);
-        connectionHolder.setConnectionTransactionActive(true);
-        TransactionSynchronizationManager.bindResource(dataSource, connectionHolder);
-    }
-
-    private void setTransactionInactive(final Connection conn) {
-        ConnectionHolder connectionHolder = new ConnectionHolder(conn);
-        connectionHolder.setConnectionTransactionActive(false);
+        connectionHolder.setConnectionTransactionActive(isTransactionActive);
         TransactionSynchronizationManager.bindResource(dataSource, connectionHolder);
     }