refactor: 사용하지 않는 메서드 제거

woowacourse · Oct 10, 2023 · 50fbb77 · 50fbb77
1 parent 6ec8ebb
commit 50fbb77
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 64 deletions.
diff --git a/app/src/main/java/com/techcourse/dao/UserDao.java b/app/src/main/java/com/techcourse/dao/UserDao.java
@@ -7,7 +7,6 @@
 import org.springframework.jdbc.core.RowMapper;
 
 import javax.sql.DataSource;
-import java.sql.Connection;
 import java.util.List;
 
 public class UserDao {
@@ -45,13 +44,6 @@ public void update(final User user) {
         log.info("update(): {}", user);
     }
 
-    public void update(final Connection connection, final User user) {
-        final String sql = "update users set (account, password, email) = (?, ?, ?) where id = ?";
-        jdbcTemplate.update(connection, sql, user.getAccount(), user.getPassword(), user.getEmail(), user.getId());
-
-        log.info("update(): {}", user);
-    }
-
     public List<User> findAll() {
         final String sql = "select id, account, password, email from users";
         final List<User> findUsers = jdbcTemplate.query(sql, userRowMapper);

diff --git a/app/src/main/java/com/techcourse/dao/UserHistoryDao.java b/app/src/main/java/com/techcourse/dao/UserHistoryDao.java
@@ -1,12 +1,11 @@
 package com.techcourse.dao;
 
 import com.techcourse.domain.UserHistory;
-import org.springframework.jdbc.core.JdbcTemplate;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.springframework.jdbc.core.JdbcTemplate;
 
 import javax.sql.DataSource;
-import java.sql.Connection;
 
 public class UserHistoryDao {
 
@@ -36,19 +35,4 @@ public void log(final UserHistory userHistory) {
                 userHistory.getCreateBy()
         );
     }
-
-    public void log(final Connection connection, final UserHistory userHistory) {
-        final var sql = "insert into user_history (user_id, account, password, email, created_at, created_by) values (?, ?, ?, ?, ?, ?)";
-
-        log.info("log(): {}", userHistory);
-
-        jdbcTemplate.update(connection, sql,
-                userHistory.getUserId(),
-                userHistory.getAccount(),
-                userHistory.getPassword(),
-                userHistory.getEmail(),
-                userHistory.getCreatedAt(),
-                userHistory.getCreateBy()
-        );
-    }
 }
diff --git a/app/src/test/java/com/techcourse/service/MockUserHistoryDao.java b/app/src/test/java/com/techcourse/service/MockUserHistoryDao.java
@@ -5,8 +5,6 @@
 import org.springframework.dao.DataAccessException;
 import org.springframework.jdbc.core.JdbcTemplate;
 
-import java.sql.Connection;
-
 public class MockUserHistoryDao extends UserHistoryDao {
 
     public MockUserHistoryDao(final JdbcTemplate jdbcTemplate) {
@@ -17,9 +15,4 @@ public MockUserHistoryDao(final JdbcTemplate jdbcTemplate) {
     public void log(final UserHistory userHistory) {
         throw new DataAccessException();
     }
-
-    @Override
-    public void log(final Connection connection, final UserHistory userHistory) {
-        throw new DataAccessException();
-    }
 }
diff --git a/jdbc/src/main/java/org/springframework/jdbc/core/JdbcExecutor.java b/jdbc/src/main/java/org/springframework/jdbc/core/JdbcExecutor.java
@@ -41,24 +41,6 @@ public <T> T execute(
         }
     }
 
-    public <T> T execute(
-            final Connection connection,
-            final String sql,
-            final Object[] args,
-            final Function<PreparedStatement, T> action) {
-
-        try (final PreparedStatement pstmt = connection.prepareStatement(sql)) {
-            log.debug("query : {}", sql);
-
-            processPreparedStatementParameter(pstmt, args);
-
-            return action.apply(pstmt);
-        } catch (SQLException e) {
-            log.error(e.getMessage(), e);
-            throw new RuntimeException(e);
-        }
-    }
-
     private void processPreparedStatementParameter(
             final PreparedStatement pstmt,
             final Object[] args

diff --git a/jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java b/jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java
@@ -5,7 +5,6 @@
 import org.springframework.jdbc.exception.IncorrectResultSizeDataAccessException;
 
 import javax.sql.DataSource;
-import java.sql.Connection;
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
@@ -36,19 +35,6 @@ public int update(final String sql, final Object... args) {
         return executor.execute(sql, args, fuction);
     }
 
-    public int update(final Connection connection, final String sql, final Object... args) {
-        final Function<PreparedStatement, Integer> fuction = pstmt -> {
-            try {
-                return pstmt.executeUpdate();
-            } catch (SQLException e) {
-                log.error(e.getMessage(), e);
-                throw new RuntimeException(e);
-            }
-        };
-
-        return executor.execute(connection, sql, args, fuction);
-    }
-
     public <T> List<T> query(final String sql, final RowMapper<T> rowMapper, final Object... args) {
         final Function<PreparedStatement, List<T>> function = pstmt -> {
             try {