refactor: final 키워드 추가

woowacourse · Sep 29, 2023 · 46d3655 · 46d3655
1 parent 210054f
commit 46d3655
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # JDBC 라이브러리 구현하기
 
 ## 1. JDBC 라이브러리 구현하기
-- [ ] SQL 쿼리 작성, 쿼리에 전달할 인자, 조회 결과를 추출하는 것에만 집중할 수 있도록 라이브러리 만들기
-  - [ ] 중복제거를 위해 JdbcTemplate을 구현한다.
-  - [ ] 기존 Dao에서 활용하던 DataSource 대신 JdbcTemplate을 사용하도록 변경한다.
+- [x] SQL 쿼리 작성, 쿼리에 전달할 인자, 조회 결과를 추출하는 것에만 집중할 수 있도록 라이브러리 만들기
+  - [x] 중복제거를 위해 JdbcTemplate을 구현한다.
+  - [x] 기존 Dao에서 활용하던 DataSource 대신 JdbcTemplate을 사용하도록 변경한다.
diff --git a/jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java b/jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java
@@ -24,8 +24,8 @@ public JdbcTemplate(final DataSource dataSource) {
     public void execute(final String sql, final PreparedStatementSetter preparedStatementSetter) {
         log.debug("query : {}", sql);
 
-        try (Connection conn = dataSource.getConnection();
-             PreparedStatement ps = conn.prepareStatement(sql)) {
+        try (final Connection conn = dataSource.getConnection();
+             final PreparedStatement ps = conn.prepareStatement(sql)) {
 
             preparedStatementSetter.set(ps);
             ps.executeUpdate();
@@ -40,8 +40,8 @@ public <T> T find(final String sql,
                       final ResultSetGetter<T> rsg) {
         log.debug("query : {}", sql);
 
-        try (Connection conn = dataSource.getConnection();
-             PreparedStatement ps = conn.prepareStatement(sql)) {
+        try (final Connection conn = dataSource.getConnection();
+             final PreparedStatement ps = conn.prepareStatement(sql)) {
 
             preparedStatementSetter.set(ps);
             return getObject(rsg, ps);
@@ -52,20 +52,19 @@ public <T> T find(final String sql,
     }
 
     private <T> T getObject(ResultSetGetter<T> rsg, PreparedStatement ps) throws SQLException {
-        try (ResultSet rs = ps.executeQuery()) {
+        try (final ResultSet rs = ps.executeQuery()) {
             if (rs.next()) {
                 return rsg.getObject(rs);
             }
             return null;
         }
     }
 
-    public <T> List<T> findAll(final String sql,
-                      final ResultSetGetter<T> rsg) {
+    public <T> List<T> findAll(final String sql, final ResultSetGetter<T> rsg) {
         log.debug("query : {}", sql);
 
-        try (Connection conn = dataSource.getConnection();
-             PreparedStatement ps = conn.prepareStatement(sql)) {
+        try (final Connection conn = dataSource.getConnection();
+             final PreparedStatement ps = conn.prepareStatement(sql)) {
 
             return getObjects(rsg, ps);
         } catch (SQLException e) {
@@ -74,9 +73,9 @@ public <T> List<T> findAll(final String sql,
         }
     }
 
-    private <T> List<T> getObjects(ResultSetGetter<T> rsg, PreparedStatement ps) throws SQLException {
-        try (ResultSet rs = ps.executeQuery()) {
-            List<T> objects = new ArrayList<>();
+    private <T> List<T> getObjects(final ResultSetGetter<T> rsg, final PreparedStatement ps) throws SQLException {
+        try (final ResultSet rs = ps.executeQuery()) {
+            final List<T> objects = new ArrayList<>();
             while (rs.next()) {
                 objects.add(rsg.getObject(rs));
             }

diff --git a/jdbc/src/main/java/org/springframework/jdbc/core/PreparedStatementSetter.java b/jdbc/src/main/java/org/springframework/jdbc/core/PreparedStatementSetter.java
@@ -17,7 +17,7 @@ public PreparedStatementSetter(final List<Object> values) {
 
     public void set(final PreparedStatement ps) throws SQLException {
         for (int i = 0; i < values.size(); i++) {
-            PreparedStatementTypeValue pstv = values.get(i);
+            final PreparedStatementTypeValue pstv = values.get(i);
             pstv.setPreparedStatement(ps, i+1);
         }
     }

diff --git a/jdbc/src/main/java/org/springframework/jdbc/core/ResultSetGetter.java b/jdbc/src/main/java/org/springframework/jdbc/core/ResultSetGetter.java
@@ -22,7 +22,7 @@ public ResultSetGetter(final Map<String, Class<?>> values, final Class<T> classF
 
     public T getObject(final ResultSet rs) throws SQLException {
         try {
-            T instance = classForObject.getConstructor().newInstance();
+            final T instance = classForObject.getConstructor().newInstance();
             setField(rs, instance);
             return instance;
         } catch (NoSuchMethodException | InvocationTargetException | InstantiationException | IllegalAccessException |
@@ -31,10 +31,10 @@ public T getObject(final ResultSet rs) throws SQLException {
         }
     }
 
-    private void setField(ResultSet rs, T instance) throws SQLException, NoSuchFieldException, IllegalAccessException {
-        for (Entry<String, SqlType> entry : values.entrySet()) {
-            Object value = getValue(rs, entry.getValue(), entry.getKey());
-            Field field = instance.getClass().getDeclaredField(entry.getKey());
+    private void setField(final ResultSet rs, final T instance) throws SQLException, NoSuchFieldException, IllegalAccessException {
+        for (final Entry<String, SqlType> entry : values.entrySet()) {
+            final Object value = getValue(rs, entry.getValue(), entry.getKey());
+            final Field field = instance.getClass().getDeclaredField(entry.getKey());
             field.setAccessible(true);
             field.set(instance, value);
         }