[Feature] - 여행 계획 코드 리팩토링 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangillee
requested changes
Jul 19, 2024
| @@ -13,8 +14,24 @@ public class GlobalExceptionHandler { | |||
| @ExceptionHandler(BadRequestException.class) | |||
| public ResponseEntity<ExceptionResponse> handleBadRequestException(BadRequestException exception) { | |||
| log.info("BAD_REQUEST_EXCEPTION :: message = {}", exception.getMessage()); | |||
There was a problem hiding this comment.
저희 Logging 정책에 대해서도 이야기를 나눠봐야겠네요.
로그 메시지 컨벤션도 정해야 할 것 같습니다.
| ) { | ||
|
|
||
| public TravelPlanPlace toPlanPlace(TravelPlanDay day, Place place) { | ||
| public TravelPlanPlace toPlanPlace(int order, TravelPlanDay day, Place place) { |
There was a problem hiding this comment.
🤔 순서를 외부에서 주입해준다.. 더 나은 방법이 있지 않을까요..
개발자가 오용하기 쉬운 코드인 것 같아요!
hangillee
approved these changes
Jul 19, 2024
1 task
eunjungL
added a commit
that referenced
this pull request
Jul 30, 2024
* feat: MethodArgumentNotValidException handler 추가 * fix: TravelPlan Request에서 order 제거 후 index 사용으로 변경
hangillee
pushed a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* feat: MethodArgumentNotValidException handler 추가 * fix: TravelPlan Request에서 order 제거 후 index 사용으로 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📸 스크린샷
🙈 참고 사항