-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - 프로필 이미지 수정 기능 및 여행기 등록 시 여행 장소마다 국가 코드 주도록 구현 #535
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
004644c
refactor(Drawer): 기존 헤드와 높이 달라 선 위치가 다른 문제 개선
simorimi cef7429
feat: 장소 필터링을 위하여 장소 등록시 countryCode를 보내도록 기능 구현
simorimi 7912136
refactor(AvatarCircle): props $네이밍 수정
simorimi 0aa2cfc
Merge branch 'develop/fe' of https://github.com/woowacourse-teams/202…
simorimi dde854e
refactor(MyTravelogue):$ 제거에 따른 수정
simorimi 932e318
refactor(usePostUploadImages): resize 와 convert 처리 내부에서 하도록 수정
simorimi aa16247
refactor(MainPage): div semantic 태그인 button으로 수정
simorimi 2eb4464
feat(ProfileImageEditModalBottomSheet): 기능 구현
simorimi 537c3e8
feat(usePutProfile): api 명세 변경에 따라 patch를 put으로, imageUrl body 값에 부여
simorimi 98076f6
refactor(AvatarCircle): props 유연하게 수정
simorimi fbc78f4
feat(useMyPage): 훅 구현
simorimi 9321263
feat(MyPage): 프로필 이미지 수정 기능 구현
simorimi 3f702c4
refactor(MyPage): 기능 단위로 pr 분리하기 위한 수정
simorimi ae9be47
refactor(SearchPage): 기능 단위로 pr 분리하기 위한 수정
simorimi 01b6786
refactor(useMyPage): useToggle 사용하도록 수정
simorimi c7561fd
refactor(common): 반복되는 타입PlaceInfo 타입으로 선언 및 수정
simorimi b889315
refactor(constants): 상수들 파일로 분리
simorimi cac5077
refactor(useMyPage): 책임에 따라 각각 커스텀 훅으로 분리
simorimi 7e6ca5e
refactor(constants): 상수 파일로 분리
simorimi f318d32
refactor(usePostUploadImages): max width, height 값 받을 수 있도록 수정
simorimi c810327
refactor(usePostUploadImages): max width, height 값 받을 수 있도록 수정
simorimi 0ec73d3
Merge branch 'feature/fe/#519' of https://github.com/woowacourse-team…
simorimi 3f18f98
refactor(useProfileInitialization): 의존성 배열 추가
simorimi 211c7d6
refactor: useCallback으로 update 함수 감싸주도록 수정
simorimi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usePostUpload
에서 한번에 처리하도록 리팩토링하셨군요!이미지가 사용되는 컴포넌트에 따라서 최대로 렌더링되는 크기가 달라서
이 부분에서 이미지 resize에 대한 max width, max height를 받게하면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 내부에 이러한 사항이 있는 줄 몰랐군요! 해당 부분 수정했습니다 고마워요!