Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 계좌번호 수정이 되지 않는 문제 해결 #844

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jinhokim98
Copy link
Contributor

issue

구현 사항

User type 생성

회원가입이 들어가며 계좌번호 관리 책임을 이벤트가 아니라 유저의 책임으로 백엔드 구조가 변경되며 api 명세가 변동되었습니다. 그래서 이에 맞춰 User 타입을 만들었습니다. 유저는 닉네임, 계좌번호, 은행 3가지를 가집니다.
또한 은행과 계좌번호를 합친 BankAccount 타입을 만들어 이를 &연산을 통해 Event와 User에 적용시켰습니다.

export type BankAccount = {
  bankName: string;
  accountNumber: string;
};

export type Event = BankAccount & {
  eventName: EventName;
  createdByGuest: boolean;
};

export type User = BankAccount & {
  nickname: Nickname;
};

api 변경 적용

useRequestPatchEventName는 이제 이름만 변경할 수 있고 useRequestPatchUser에서 계좌번호와 은행을 바꿀 수 있습니다.
닉네임 수정은 차후에 적용하겠습니다.

🫡 참고사항

@jinhokim98 jinhokim98 added this to the v2.2.0 milestone Dec 7, 2024
@jinhokim98 jinhokim98 requested review from pakxe, soi-ha and Todari December 7, 2024 12:31
@jinhokim98 jinhokim98 self-assigned this Dec 7, 2024
@jinhokim98 jinhokim98 linked an issue Dec 7, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 7, 2024

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api변경에 맞춰 수정 죻섭니댱~ 👍

Copy link
Contributor

@Todari Todari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀🚀🚀🚀🚀🚀

@jinhokim98 jinhokim98 merged commit 4c383f1 into fe-dev Dec 11, 2024
2 checks passed
@jinhokim98 jinhokim98 deleted the feature/#843 branch December 11, 2024 06:32
jinhokim98 added a commit that referenced this pull request Dec 11, 2024
* style: User 타입 분리

* fix: 백엔드 계좌번호 구조 변경으로 인한 api 변동을 반영
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] 계좌번호 수정이 되지 않는 문제 해결
4 participants