[BE] 이미지 병렬 업로드 기능 추가 #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 23 files 23 suites 3s ⏱️ Results for commit dcb5521. |
kunsanglee
approved these changes
Nov 5, 2024
| .toList(); | ||
|
|
||
| CompletableFuture<List<String>> result = CompletableFuture.allOf(futures.toArray(new CompletableFuture[futures.size()])) |
There was a problem hiding this comment.
Suggested change
| CompletableFuture<List<String>> result = CompletableFuture.allOf(futures.toArray(new CompletableFuture[futures.size()])) | |
| CompletableFuture<List<String>> result = CompletableFuture.allOf(new CompletableFuture[0])) |
futures 리스트의 정확한 크기가 필요한 것이 아니라, 명시적인 타입을 제공하고 배열 리사이징 최적화를 이용할 수 있도록 new CompletableFuture[0]를 매개변수로 넘겨주는게 더 좋겠네요 👍
There was a problem hiding this comment.
@Arachneee 확인 후 자체 머지 해주세요.
Arachneee
added a commit
that referenced
this pull request
Nov 13, 2024
* feat: 이미지 병렬 업로드 기능 추가 * feat: 이미지 업로드 예외 처리 추가 * refactor: 불필요 배열 사이즈 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 사항
여러 이미지를 순차적으로 업로드하던 기능을 병렬로 업로드할 수 있게 변경합니다.
[10MB 이미지 10개]
순차 업로드 : 5.5s
병렬 업로드 : 2.1s
로 응답시간을 개선했습니다.
추가로 S3Client 호출 시에 발생하는 예외를 추적할 수 있도록 HaengdongException 생성자에 Throwable 을 추가했습니다.