Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 에러 페이지 구현 #809

Merged
merged 3 commits into from
Oct 24, 2024
Merged

[FE] 에러 페이지 구현 #809

merged 3 commits into from
Oct 24, 2024

Conversation

pakxe
Copy link
Contributor

@pakxe pakxe commented Oct 24, 2024

issue

구현 목적

현재 UnpredictableErrorBoundary에서 에러가 잡혔을 경우 '에러가 발생했습니다.'라는 텍스트만 뜹니다.

그래서 에러 페이지를 꾸며보았습니다.

구현 사항

에러 페이지를 구현합니다.

image

@pakxe pakxe added 🖥️ FE Frontend ⚙️ feat feature labels Oct 24, 2024
@pakxe pakxe added this to the v2.1.4 milestone Oct 24, 2024
@pakxe pakxe self-assigned this Oct 24, 2024
@pakxe pakxe linked an issue Oct 24, 2024 that may be closed by this pull request
@pakxe pakxe changed the base branch from main to fe-dev October 24, 2024 12:15
@pakxe pakxe requested review from jinhokim98, soi-ha and Todari October 24, 2024 12:15
Copy link

Test Results

 23 files   23 suites   3s ⏱️
140 tests 140 ✅ 0 💤 0 ❌
144 runs  144 ✅ 0 💤 0 ❌

Results for commit 87e61a4.

Copy link

Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

행댕이 그리느라 너무 고생 많았어요~~
덕분에 다양한 상황에서 행댕이들을 활용할 수 있을 것 같아요

height="80vh"
css={{alignContent: 'center'}}
>
<Image src={getImageUrl('cryingDog', 'webp')} width="160px" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우는 행댕이ㅠㅠㅠㅠㅠ, 나중에 대체 이미지도 추가해주면 좋을 것 같아요~~

Copy link

Copy link
Contributor

@Todari Todari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우리의 MD 웨디...
고생 많았어요 고마와요옹

Copy link

@pakxe pakxe merged commit ea1db62 into fe-dev Oct 24, 2024
2 checks passed
@pakxe pakxe deleted the feature/#807 branch October 24, 2024 12:21
@Todari Todari mentioned this pull request Oct 24, 2024
pakxe added a commit that referenced this pull request Oct 24, 2024
* feat: 에러 페이지 구현

* test: 에러 페이지 테스트에서 개선된 페이지의 텍스트를 반영

* feat: 대체 이미지 png로 설정
This was referenced Oct 24, 2024
@soi-ha
Copy link
Contributor

soi-ha commented Oct 24, 2024

진초ㅑ 너무 귀어ㅕ워요,,

jinhokim98 pushed a commit that referenced this pull request Oct 24, 2024
* feat: 에러 페이지 구현

* test: 에러 페이지 테스트에서 개선된 페이지의 텍스트를 반영

* feat: 대체 이미지 png로 설정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] 에러 페이지 구현
4 participants