Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 768 이상의 해상도에서 랜딩페이지 좌우 패딩 오류 #808

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Todari
Copy link
Contributor

@Todari Todari commented Oct 24, 2024

issue

구현 �목적

768 이상의 해상도에서 랜딩페이지 좌우의 패딩에 오류가 있습니다.

KakaoTalk_Video_2024-10-24-20-14-02.mp4

구현 사항

  • 기존에 globalStyle 에서 max-width:768px 을 선언해 주어서, global로 해당 해상도가 적용되는 문제였습니다.
  • mainPage가 랜딩될 때, 이 attribute를 100vw로 변경해 주도록 설정해 주었습니다.

@Todari Todari added 🖥️ FE Frontend 🚨 bug bug 🔍 QC quality check labels Oct 24, 2024
@Todari Todari added this to the v2.1.4 milestone Oct 24, 2024
@Todari Todari requested review from pakxe, soi-ha and jinhokim98 October 24, 2024 12:13
@Todari Todari self-assigned this Oct 24, 2024
Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

랜딩페이지 깎는 토다리 랜깎토 고생했어요

Copy link

Copy link
Contributor

@pakxe pakxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@pakxe pakxe merged commit 2688782 into fe-dev Oct 24, 2024
2 checks passed
@pakxe pakxe deleted the feature/#805 branch October 24, 2024 12:20
@Todari Todari mentioned this pull request Oct 24, 2024
pakxe pushed a commit that referenced this pull request Oct 24, 2024
* fix: mainPage 768px 이상 해상도에서 제대로 작동하지 않던 오류 해결

* style: lint 적용
This was referenced Oct 24, 2024
jinhokim98 pushed a commit that referenced this pull request Oct 24, 2024
* fix: mainPage 768px 이상 해상도에서 제대로 작동하지 않던 오류 해결

* style: lint 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 bug bug 🖥️ FE Frontend 🔍 QC quality check
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants