Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] favicon.ico 404 오류 해결 #803

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[FE] favicon.ico 404 오류 해결 #803

merged 1 commit into from
Oct 24, 2024

Conversation

jinhokim98
Copy link
Contributor

issue

구현 사항

public 디렉토리 내로 이동해서 상대 경로에서 절대 경로 변경

이전에는 href가 상대 경로를 참조하고 있어서 이슈와 같이 event 페이지로 들어갔을 때 404를 터뜨립니다

favicon을 client에서 public 디렉토리 내부로 옮겨서 오류를 해결했습니다.

🫡 참고사항

@jinhokim98 jinhokim98 added this to the v2.1.3 milestone Oct 24, 2024
@jinhokim98 jinhokim98 requested review from pakxe, soi-ha and Todari October 24, 2024 08:01
@jinhokim98 jinhokim98 self-assigned this Oct 24, 2024
@jinhokim98 jinhokim98 linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단하게 에러 해결 👍

Copy link
Contributor

@Todari Todari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public path 씁시다

@Todari Todari merged commit 90fa201 into fe-dev Oct 24, 2024
2 checks passed
@Todari Todari deleted the feature/#786 branch October 24, 2024 09:05
@Todari Todari mentioned this pull request Oct 24, 2024
Todari pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] favicon.ico 404 오류 해결
3 participants