Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] carousel 에 maxWidth가 적용되지 않아 768 이상 해상도에서 짤리는 문제 #801

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Todari
Copy link
Contributor

@Todari Todari commented Oct 24, 2024

issue

구현 목적

  • 768px 이상의 해상도에서 carousel이 잘리는 문제가 발생했습니다.
    image

구현 사항

  • Carousel component에서 이미지 카드의 max-width를 적용해 줌으로써 해결하였습니다.

@Todari Todari added 🖥️ FE Frontend ⚙️ feat feature labels Oct 24, 2024
@Todari Todari added this to the v2.1.3 milestone Oct 24, 2024
@Todari Todari requested review from pakxe, soi-ha and jinhokim98 October 24, 2024 07:39
@Todari Todari self-assigned this Oct 24, 2024
Copy link

Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요~~ 고생 많았습니다!

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

놓친 부분을 잘 캐치해서 수정해주다니! 고마워용

@Todari Todari merged commit e2d5ba5 into fe-dev Oct 24, 2024
2 checks passed
@Todari Todari deleted the feature/#765 branch October 24, 2024 09:05
@Todari Todari mentioned this pull request Oct 24, 2024
Todari added a commit that referenced this pull request Oct 24, 2024
* fix: carousel pc 해상도에서 잘리는 문제 해결

* style: carousel design 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] carousel 에 maxWidth가 적용되지 않아 768 이상 해상도에서 짤리는 문제
3 participants