Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] v2.1.1 배포 과정에서의 문제 해결 #763

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

jinhokim98
Copy link
Contributor

@jinhokim98 jinhokim98 commented Oct 17, 2024

issue

구현 사항

[FE] v2.1.1 배포 과정에서의 문제를 해결했습니다.
merge 과정에서 IconButton에 삭제했던 불주사가 다시 부활하여 삭제하였습니다.
useBanner가 import되고 있지 않았습니다.

Co-authored-by: TaehunLee <[email protected]>
Co-authored-by: Pakxe <[email protected]>
Co-authored-by: Soyeon Choe <[email protected]>
@jinhokim98 jinhokim98 added this to the v2.1.1 milestone Oct 17, 2024
@jinhokim98 jinhokim98 requested review from pakxe, soi-ha and Todari October 17, 2024 06:58
@jinhokim98 jinhokim98 linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link
Contributor

@pakxe pakxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~~

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다시 가보자고 ~

Copy link
Contributor

@Todari Todari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가시보죠

Copy link

Test Results

 23 files   23 suites   4s ⏱️
140 tests 140 ✅ 0 💤 0 ❌
144 runs  144 ✅ 0 💤 0 ❌

Results for commit 4a6a4a9.

Copy link

@jinhokim98 jinhokim98 merged commit dbded65 into main Oct 17, 2024
5 checks passed
@jinhokim98 jinhokim98 deleted the hotfix/#762 branch October 17, 2024 07:01
@Todari Todari mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] v2.1.1 배포 과정에서의 문제 해결
4 participants