-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 지출 내역 추가 플로우에서 참여 인원의 토큰의 x버튼에 낭독기 커서가 가도록 함 #759
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9ebbf66
chore: @sentry/webpack-plugin 라이브러리 2.22.0 -> 2.22.5로 업데이트
pakxe e988844
feat: Icon 컴포넌트를 IconButton으로 감싸 버튼으로 인식되도록 함
pakxe 7355b00
feat: ICON으로 사용되는 모든 이미지에 aria-label 부착
pakxe 1cecfda
feat: 하드코딩된 IconType의 타입을 ICON 객체의 프로퍼티 키 값으로 하도록 수정
pakxe fd6256e
style: 코드 컨벤션에 맞도록 수정
pakxe b79987b
chore: 사용되지 않는 import 제거
pakxe 8138b11
chore: 사용하지 않는 컴포넌트 제거
pakxe e0050b9
feat: onClick을 Icon에서 IconButton으로 이동
pakxe 2b42e12
chore: 사용하지 않는 컴포넌트 제거
pakxe 59e43d2
chore: 사용하지 않는 컴포넌트 제거
pakxe 77ea2ff
feat: ICON에 달아준 aria-label을 모두 제거
pakxe 2d1bb16
feat: IconButton 컴포넌트를 사용하는 대부분의 위치에 aria-label 속성 추가
pakxe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: 하드코딩된 IconType의 타입을 ICON 객체의 프로퍼티 키 값으로 하도록 수정
- Loading branch information
commit 1cecfdabd447a097740d9b74f46559fd180ff39f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,9 @@ | ||
import {Theme} from '@theme/theme.type'; | ||
import {ColorKeys} from '@token/colors'; | ||
|
||
export type IconType = | ||
| 'inputDelete' | ||
| 'buljusa' | ||
| 'rightChevron' | ||
| 'search' | ||
| 'error' | ||
| 'confirm' | ||
| 'trash' | ||
| 'trashMini' | ||
| 'check' | ||
| 'x' | ||
| 'pencilMini' | ||
| 'toss' | ||
| 'meatballs' | ||
| 'editPencil' | ||
| 'heundeut' | ||
| 'photoButton'; | ||
import {ICON} from './Icon'; | ||
|
||
export type IconType = keyof typeof ICON; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 와 이거 매번 추가해주기 귀찮았는데~~ 너무 좋아요 |
||
|
||
export type IconColor = ColorKeys; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀🚀🚀