Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 입금 완료를 했는데 송금 버튼이 눌리는 버그 #676

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jinhokim98
Copy link
Contributor

issue

구현 사항

BankSendButton에 isDeposited prop을 넣어줬습니다.
기존에는 price가 0보다 작거나 같은지만 넣어줬다면 isDeposited 값도 넣어줍니다.

<BankSendButton
            clipboardText={clipboardText}
            onBankButtonClick={onBankButtonClick}
            isDeposited={price <= 0 || isDeposited}
          />

image

🫡 참고사항

@jinhokim98 jinhokim98 added this to the v2.0.0 milestone Sep 26, 2024
@jinhokim98 jinhokim98 self-assigned this Sep 26, 2024
Copy link

@jinhokim98 jinhokim98 linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link
Contributor

@Todari Todari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

Copy link
Contributor

@pakxe pakxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 버그가 있었군요

@soi-ha soi-ha merged commit a8db3a5 into fe-dev Sep 26, 2024
2 checks passed
@soi-ha soi-ha deleted the feature/#674 branch September 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] 입금 완료를 했는데 송금 버튼이 눌리는 버그
4 participants