Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] GlobalStyle tnum 삭제 #648

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[FE] GlobalStyle tnum 삭제 #648

merged 1 commit into from
Sep 26, 2024

Conversation

Todari
Copy link
Contributor

@Todari Todari commented Sep 26, 2024

issue

구현 목적

�코드 수정 중 잘못 입력된 tnum attribute로 인해 예상된 폰트 디자인이 출력되지 않습니다.

구현 내용

tnum attribute 를 제거했습니다.

🫡 참고사항

@Todari Todari added 🖥️ FE Frontend 🔍 QC quality check labels Sep 26, 2024
@Todari Todari added this to the v2.0.0 milestone Sep 26, 2024
@Todari Todari self-assigned this Sep 26, 2024
Copy link

@Todari Todari linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳쓰

@@ -142,7 +142,6 @@ export const GlobalStyle = css`
sans-serif;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
font-feature-settings: 'tnum';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 덕분에 새로운 것을 알고갑니다~~

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

죠씁니댜

@soi-ha soi-ha merged commit 2557ee9 into fe-dev Sep 26, 2024
2 checks passed
@soi-ha soi-ha deleted the feature/#647 branch September 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥️ FE Frontend 🔍 QC quality check
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] GlobalStyle tnum 삭제
4 participants