Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] API 명세서에 작성된 예외 최신화 및 코드 수정 #645

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

kunsanglee
Copy link
Contributor

issue

구현 사항

노션 API 명세서에 작성된 예외 상황별 예외코드와 메세지를 백엔드 코드에 맞게 동기화하고,
HaengdongErrorCode enum에서 더이상 사용하지 않는 TOKEN_EXPIRED을 삭제했습니다.

지출 상세 수정 API 에서 사용하는 DTO BillDetailUpdateRequestisFixed 필드의 잘못된 검증 메세지를 제거하고 primitive 타입으로 변환했습니다. 또 참여자 추가 API 에서 사용하는 DTO MemberSaveRequestname 필드에 검증을 추가했습니다.

중점적으로 리뷰받고 싶은 부분(선택)

어떤 부분을 중점으로 리뷰했으면 좋겠는지 작성해주세요.

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

@kunsanglee kunsanglee added ⌨️ BE Backend 🚧 refactor refactoring labels Sep 26, 2024
@kunsanglee kunsanglee added this to the v2.0.0 milestone Sep 26, 2024
@kunsanglee kunsanglee self-assigned this Sep 26, 2024
Copy link

Test Results

 22 files   22 suites   3s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
130 runs  130 ✅ 0 💤 0 ❌

Results for commit 880f179.

Copy link
Contributor

@khabh khabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 🙇‍♀️

@Arachneee Arachneee merged commit 8605c78 into be-dev Sep 26, 2024
3 checks passed
@Arachneee Arachneee deleted the feature/#642 branch September 26, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ BE Backend 🚧 refactor refactoring
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants