-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 참여인원이 많을 때, 지출 내역 카드에서 멤버 칩의 레이아웃이 깨지는 문제 #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
꼼꼼한 확인 감사합니다~~
@@ -3,4 +3,6 @@ import {css} from '@emotion/react'; | |||
export const chipGroupStyle = css({ | |||
display: 'flex', | |||
gap: '0.25rem', | |||
flexWrap: 'wrap', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flex wrap 좋아요.!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이전에 chip 깨지는 모양이 마치 일본 식당의 메뉴 간판(?) 같네요.
아름답게 수정해줘서 감샴댜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
또 버그를 줏어먹으셨군요. 역시 토달;;; 맛있는 것만 먹어야할텐데.... 사소한 부분이지만 제안하고 싶은게 있는데요..! 개선 결과 캡쳐본도 넣어주면 더 좋을 것 같아요 👍
@@ -3,4 +3,6 @@ import {css} from '@emotion/react'; | |||
export const chipGroupStyle = css({ | |||
display: 'flex', | |||
gap: '0.25rem', | |||
flexWrap: 'wrap', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오!! 👍 이런 부분을 신경썼어야 했군요. 역시 css 신 씨신
issue
구현 목적
위 사진처럼 일정 길이 이상으로 칩이 길어진다면 layout이 깨지는 현상이 발생합니다.
이를 해결해서 예상치 못한 화면이 유저에게 출력되지 않도록 하고자 합니다.
구현 내용
ChipGroup.tsx