Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 참여인원이 많을 때, 지출 내역 카드에서 멤버 칩의 레이아웃이 깨지는 문제 #628

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

Todari
Copy link
Contributor

@Todari Todari commented Sep 25, 2024

issue

구현 목적

Image

위 사진처럼 일정 길이 이상으로 칩이 길어진다면 layout이 깨지는 현상이 발생합니다.
이를 해결해서 예상치 못한 화면이 유저에게 출력되지 않도록 하고자 합니다.

구현 내용

ChipGroup.tsx

export const chipGroupStyle = css({
  display: 'flex',
  gap: '0.25rem',
  flexWrap: 'wrap',
  overflow: 'hidden',
});
  • chipGroupStyle에 flexWrap과 overflow 속성을 사용하여 예상된 길이보다 길어지지 않도록 설정

@Todari Todari added 🖥️ FE Frontend 🚨 bug bug 🔍 QC quality check labels Sep 25, 2024
@Todari Todari added this to the v2.0.0 milestone Sep 25, 2024
@Todari Todari self-assigned this Sep 25, 2024
Copy link

Copy link

Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼한 확인 감사합니다~~

@@ -3,4 +3,6 @@ import {css} from '@emotion/react';
export const chipGroupStyle = css({
display: 'flex',
gap: '0.25rem',
flexWrap: 'wrap',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex wrap 좋아요.!

Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전에 chip 깨지는 모양이 마치 일본 식당의 메뉴 간판(?) 같네요.
아름답게 수정해줘서 감샴댜

Copy link
Contributor

@pakxe pakxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

또 버그를 줏어먹으셨군요. 역시 토달;;; 맛있는 것만 먹어야할텐데.... 사소한 부분이지만 제안하고 싶은게 있는데요..! 개선 결과 캡쳐본도 넣어주면 더 좋을 것 같아요 👍

@@ -3,4 +3,6 @@ import {css} from '@emotion/react';
export const chipGroupStyle = css({
display: 'flex',
gap: '0.25rem',
flexWrap: 'wrap',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오!! 👍 이런 부분을 신경썼어야 했군요. 역시 css 신 씨신

@soi-ha soi-ha merged commit bcae9bc into fe-dev Sep 26, 2024
2 checks passed
@soi-ha soi-ha deleted the feature/#625 branch September 26, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 bug bug 🖥️ FE Frontend 🔍 QC quality check
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FE] 참여인원이 많을 때, 지출 내역 카드에서 멤버 칩의 레이아웃이 깨지는 문제
4 participants