[BE] 계좌 정보를 은행 정보과 계좌 번호로 분리해서 응답 #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3s ⏱️ Results for commit fde29e7. |
kunsanglee
reviewed
Sep 24, 2024
Comment on lines
+101
to
+105
| String[] bankNameAndAccountNumber = account.split(" "); | ||
| if (bankNameAndAccountNumber.length > 0) { | ||
| return bankNameAndAccountNumber[0]; | ||
| } | ||
| return ""; |
There was a problem hiding this comment.
bankName, accountNumber에 쓰인 문자열 상수로 선언 해주세요
khabh
approved these changes
Sep 24, 2024
kunsanglee
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 사항
논의하고 싶은 부분(선택)
현재 엔티티 내부에 account 필드가 있습니다.
account를 bankName과 accountNumber로 변환해야 하지만, 그러지 않았습니다.
이유는 현재 스키마 마이그레이션이 진행 중으로, 관련 작업에 영향을 주지 않기 위함입니다.
🫡 참고사항