[FE] BottomSheet 애니메이션이 적용되지 않던 오류 수정 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jinhokim98
approved these changes
Aug 22, 2024
soi-ha
reviewed
Aug 22, 2024
| @@ -3,7 +3,7 @@ import {Title, FixedButton, ListButton, Button} from 'haengdong-design'; | |||
| import {useOutletContext} from 'react-router-dom'; | |||
|
|
|||
| import StepList from '@components/StepList/StepList'; | |||
| import {ModalBasedOnMemberCount} from '@components/Modal/index'; | |||
| import {ModalBasedOnMemberCount, SetAllMemberListModal} from '@components/Modal/index'; | |||
There was a problem hiding this comment.
SetAllMemberListModal import가 추가되었는데 어디서 사용하고 있는지 못 찾겠네요ㅜㅜ 어디서 사용되고 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 목적
BottomSheet의 애니메이션이 적용되지 않던 버그가 있어 이를 수정합니다.
구현 사항
BottomSheet 구조상, 조건부 렌더링이 아닌,
isOpen상태의 변화를 통해 애니메이션을 적용해 주는 것이기 때문에, 조건부 렌더링을 진행하면 애니메이션이 적용되지 않습니다.조건부 렌더링을 상태를 이용하도록 변경해 주었습니다.
🫡 참고사항
런칭페스티벌을 앞두고, 급하게 변경사항을 적용했습니다.
간단한 인원 변동 추가 바텀시트와 인원 수정 바텀시트는 잘 작동하지만,
여러 상태가 엮여있는 전체 참여자 바텀시트와 금액 수정 바텀시트는 여전히 작동하지 않습니다.
바텀시트 관련한 부분들도 수정을 직접 해보니 굉장히 결합도가 높고 불필요한 코드가 많아보여요
레벨 4에서 할일이 정말 고봉밥이네요...