[FE] 지출 내역 추가 시 금액에 숫자 외 다른 문자 입력 가능한 버그 수정 #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jinhokim98
approved these changes
Aug 22, 2024
| @@ -22,7 +22,7 @@ const SetEventPasswordPage = () => { | |||
| labelText="비밀번호" | |||
| errorText={errorMessage} | |||
| value={password} | |||
| type="secret" | |||
| type="number" | |||
There was a problem hiding this comment.
혹시 여기 type이 number로 바뀐 이유가 있을까요?
soi-ha
approved these changes
Aug 22, 2024
| @@ -108,7 +108,7 @@ const BillStepItem: React.FC<BillStepItemProps> = ({ | |||
| <EditableItem.Input | |||
| placeholder="0" | |||
| type="number" | |||
| value={billInput.price || ''} | |||
| value={billInput.price ?? null} | |||
There was a problem hiding this comment.
와 이거 제가 어제 수정하면서 고민했던 건데!
빈 문자열이 아니라 null로 줘도 될것 같은데? 딱 이 생각을 했었거든요..
그런데 일단 빈 문자열로도 잘 동작하길래 슥- 생각만 하고 넘어갔었는데.. 이런 안일함이 버그를 발생시켰다니.. 대-충격;;;
버그 해결해줘서 너무 고마워요 토다리 ㅜㅜ
pakxe
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 목적
2024-08-22.6.33.15.mov
구현 사항
type=number로 제한되어 있는 input에 초기값으로''가 주어지다 보니 이 부분에서 문자열을 받으면서 버그가 발생함''이 아닌null을 줌으로써 해결함