[FE] 관리자 로그인 페이지에서 스위치가 관리로 활성화되지 않는 버그 #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todari
approved these changes
Aug 21, 2024
Comment on lines
+1
to
+42
| import {useState} from 'react'; | ||
|
|
||
| import validateEventPassword from '@utils/validate/validateEventPassword'; | ||
|
|
||
| import RULE from '@constants/rule'; | ||
|
|
||
| import useRequestPostLogin from './queries/useRequestPostLogin'; | ||
|
|
||
| const useEventLogin = () => { | ||
| const [password, setPassword] = useState(''); | ||
| const [errorMessage, setErrorMessage] = useState<string | null>(null); | ||
| const [canSubmit, setCanSubmit] = useState(false); | ||
| const {mutate: postLogin} = useRequestPostLogin(); | ||
|
|
||
| const submitPassword = async (event: React.FormEvent<HTMLFormElement>) => { | ||
| event.preventDefault(); | ||
|
|
||
| postLogin({password}, {onError: () => setErrorMessage('비밀번호가 틀렸어요')}); | ||
| }; | ||
|
|
||
| const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| const newValue = event.target.value; | ||
| const validation = validateEventPassword(newValue); | ||
| setErrorMessage(validation.errorMessage); | ||
|
|
||
| if (validation.isValid) { | ||
| setPassword(newValue); | ||
| } | ||
|
|
||
| setCanSubmit(newValue.length === RULE.maxEventPasswordLength); | ||
| }; | ||
|
|
||
| return { | ||
| password, | ||
| errorMessage, | ||
| handleChange, | ||
| canSubmit, | ||
| submitPassword, | ||
| }; | ||
| }; | ||
|
|
||
| export default useEventLogin; |
There was a problem hiding this comment.
ㅋㅋㅋ 복붙이 끝이긴 하지만ㅋㅋ
Comment on lines
+44
to
+47
| { | ||
| path: ROUTER_URLS.eventLogin, | ||
| element: <EventLoginPage />, | ||
| }, |
There was a problem hiding this comment.
별도 페이지가 아니라, event 내부로 넣어버렸군뇨 좋와요~!
There was a problem hiding this comment.
같은 형식의 url을 가지고 있어서 안으로 옮기고 중복되는 MainLayout TopNav를 지워봤어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 사항
관리자 로그인 페이지에서 스위치가 관리로 활성화되지 않는 버그를 해결했습니다.
관리자로 접속해서 들어간 페이지인데 관리가 활성화되지 않아서 유저가 나는 지금 어디있는거지라고 생각할 것 같아서, 너는 지금 관리페이지에 들어왔어 하지만 너는 "쿠키 is me"가 없기 때문에 관리할 수 없어 비밀번호 입력해! 라는 것을 더 잘 표시하기 위해 로그인 페이지에도 관리 탭이 활성화됐음을 강조했어요.
자세한 것은 영상으로
2024-08-21-23-56-45.mp4
추가로 useEventLogin 훅을 만들어서 EventLogin 관련 로직을 훅으로 분리했어요.
🫡 참고사항