Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] 전체 금액 수정 시 계산이 마이너스가 되는 문제 #442

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[FE] 전체 금액 수정 시 계산이 마이너스가 되는 문제 #442

merged 1 commit into from
Aug 21, 2024

Conversation

jinhokim98
Copy link
Contributor

issue

구현 사항

전체 금액 수정 시 계산이 마이너스가 되는 문제를 해결했어요.
훅에 현재 입력 값이 아니라 서버에서 온 값으로 넣어줘서 변경 값으로 인식을 하지 않았던 문제입니다.

🫡 참고사항

@jinhokim98 jinhokim98 added this to the lev3 milestone Aug 21, 2024
@jinhokim98 jinhokim98 requested review from pakxe, soi-ha and Todari August 21, 2024 07:41
@jinhokim98 jinhokim98 self-assigned this Aug 21, 2024
@jinhokim98 jinhokim98 linked an issue Aug 21, 2024 that may be closed by this pull request
[FE] 전체 금액 수정 시 계산이 마이너스가 되는 문제 #439
Closed
soi-ha
soi-ha approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@soi-ha soi-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 한줄이 쿠키를 고통받게 했다니..
해결 추추카링

@jinhokim98 jinhokim98 merged commit c68101b into fe-dev Aug 21, 2024
1 check passed
@jinhokim98 jinhokim98 deleted the feature/#439 branch August 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soi-ha soi-ha soi-ha approved these changes

@pakxe pakxe pakxe approved these changes

@Todari Todari Awaiting requested review from Todari

Assignees

@jinhokim98 jinhokim98

Labels
🚨 bug bug 🖥️ FE Frontend High
Projects
2024-haeng-dong
Status: ✅ Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

[FE] 전체 금액 수정 시 계산이 마이너스가 되는 문제
3 participants
@jinhokim98 @pakxe @soi-ha