Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] html height 100% #434

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[FE] html height 100% #434

merged 1 commit into from
Aug 21, 2024

Conversation

soi-ha
Copy link
Contributor

@soi-ha soi-ha commented Aug 21, 2024

issue

구현 사항

body 태그에 heigth가 100%임에도 배경색상이 잘리는 문제가 발생.
body 태그의 부모에 높이가 존재하지 않아서 발생한 문제이다.
따라서 body 태그의 부모인 html 태그에 height를 100% 추가해주었다.

🫡 참고사항

@soi-ha soi-ha added this to the lev3 milestone Aug 21, 2024
@soi-ha soi-ha self-assigned this Aug 21, 2024
@pakxe pakxe self-requested a review August 21, 2024 06:31
Copy link
Contributor

@jinhokim98 jinhokim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세심한 발견 대단스

@soi-ha soi-ha merged commit bd3f3e2 into fe-dev Aug 21, 2024
1 check passed
@soi-ha soi-ha deleted the feature/#421 branch August 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants