[FE] 지출 액션 수정, 삭제 기능 구현 #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JUHA <[email protected]> Co-authored-by: Arachne <[email protected]>
Arachneee
reviewed
Aug 5, 2024
| const memberActions = stepList.filter(step => step.type !== 'BILL').flatMap(step => step.actions); | ||
|
|
||
| const hasNextMemberAction = (name: string, sequence: number) => { | ||
| return memberActions.find(action => action.name === name && action.sequence > sequence) !== undefined; |
There was a problem hiding this comment.
Suggested change
| return memberActions.find(action => action.name === name && action.sequence > sequence) !== undefined; | |
| return memberActions.some(action => action.name === name && action.sequence > sequence); |
find보다 some 메소드를 사용하는 것은 어떨까요?
There was a problem hiding this comment.
아닛 그런 방법이~!!!~ 너무 좋은 의견이에요
코드가 바뀌긴했지만 이런 상황나오면 some 사용해야지!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 사항
기능 구현 전 반영 사항
issue와 연관된 기능 구현
현재는 StepItem이 props로 받은 bills를 배열로 BillItem을 뿌리고 있음. 즉. 밖에서 직접 사용할 때는 bills props에 배열을 넘겨주고 있기 때문에 각각의 BillItem을 클릭할 수 없음. 따라서 디자인시스템의 StepItem에서 BillItem 각각을 클릭할 수 있도록 수정해야 함
🫡 참고사항