Skip to content

Commit

Permalink
refactor: 배치 사이즈 조절
Browse files Browse the repository at this point in the history
  • Loading branch information
Arachneee committed Sep 26, 2024
1 parent d4a33f7 commit 593248f
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import server.haengdong.application.response.MemberAppResponse;
import server.haengdong.application.response.MembersDepositAppResponse;
import server.haengdong.application.response.MembersSaveAppResponse;
import server.haengdong.domain.bill.Bill;
import server.haengdong.domain.bill.BillDetailRepository;
import server.haengdong.domain.bill.BillRepository;
import server.haengdong.domain.event.Event;
Expand Down Expand Up @@ -67,11 +68,10 @@ private boolean isDuplicatedMemberNames(Set<String> uniqueMemberNames, Event eve
public List<MemberAppResponse> getCurrentMembers(String token) {
Event event = getEvent(token);

List<Member> currentMembers = billRepository.findCurrentMembers(event);
if (currentMembers.isEmpty()) {
currentMembers = memberRepository.findAllByEvent(event);
}
return currentMembers.stream()
return billRepository.findFirstByEventOrderByIdDesc(event)
.map(Bill::getMembers)
.orElseGet(() -> memberRepository.findAllByEvent(event))
.stream()
.map(MemberAppResponse::of)
.toList();
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package server.haengdong.domain.bill;

import java.util.List;
import java.util.Optional;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.Query;
import org.springframework.stereotype.Repository;
import server.haengdong.domain.event.Event;
import server.haengdong.domain.member.Member;

@Repository
public interface BillRepository extends JpaRepository<Bill, Long> {
Expand All @@ -19,15 +19,5 @@ public interface BillRepository extends JpaRepository<Bill, Long> {
""")
List<Bill> findAllByEvent(Event event);

@Query("""
select bd.member
from BillDetail bd
where bd.bill = (select b
from Bill b
where b.event = :event
order by bd.bill.id desc
limit 1)
""")
List<Member> findCurrentMembers(Event event);
Optional<Bill> findFirstByEventOrderByIdDesc(Event event);
}
1 change: 1 addition & 0 deletions server/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ spring:
ddl-auto: create
properties:
hibernate:
default_batch_fetch_size: 30
format_sql: true
jdbc.time_zone: Asia/Seoul
show-sql: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,10 +362,12 @@ void getCurrentMembersTest() {
Member member1 = MEMBER1;
Member member2 = MEMBER2;
Member member3 = MEMBER3;
Bill bill = Bill.create(event, "title", 100000L, List.of(member1, member2, member3));
Bill bill1 = Bill.create(event, "title1", 100000L, List.of(member1));
Bill bill2 = Bill.create(event, "title2", 200000L, List.of(member1, member2, member3));
Bill bill3 = Bill.create(event, "title2", 200000L, List.of(member1, member2, member3));
eventRepository.save(event);
memberRepository.saveAll(List.of(member1, member2, member3));
billRepository.save(bill);
billRepository.saveAll(List.of(bill1, bill2, bill3));

List<MemberAppResponse> currentMembers = memberService.getCurrentMembers(event.getToken());

Expand Down

0 comments on commit 593248f

Please sign in to comment.