Skip to content

Commit

Permalink
feat: 지출 내역 추가 플로우에서 참여 인원의 토큰의 x버튼에 낭독기 커서가 가도록 함 (#759)
Browse files Browse the repository at this point in the history
* chore: @sentry/webpack-plugin 라이브러리 2.22.0 -> 2.22.5로 업데이트

* feat: Icon 컴포넌트를 IconButton으로 감싸 버튼으로 인식되도록 함

* feat: ICON으로 사용되는 모든 이미지에 aria-label 부착

* feat: 하드코딩된 IconType의 타입을 ICON 객체의 프로퍼티 키 값으로 하도록 수정

* style: 코드 컨벤션에 맞도록 수정

* chore: 사용되지 않는 import 제거

* chore: 사용하지 않는 컴포넌트 제거

* feat: onClick을 Icon에서 IconButton으로 이동

* chore: 사용하지 않는 컴포넌트 제거

* chore: 사용하지 않는 컴포넌트 제거

* feat: ICON에 달아준 aria-label을 모두 제거

* feat: IconButton 컴포넌트를 사용하는 대부분의 위치에 aria-label 속성 추가
  • Loading branch information
pakxe authored Oct 17, 2024
1 parent 27a8d88 commit 1843235
Show file tree
Hide file tree
Showing 23 changed files with 71 additions and 401 deletions.
88 changes: 44 additions & 44 deletions client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@eslint/compat": "^1.1.0",
"@eslint/js": "^9.6.0",
"@jest/types": "^29.6.3",
"@sentry/webpack-plugin": "^2.22.0",
"@sentry/webpack-plugin": "^2.22.5",
"@storybook/addon-essentials": "^8.2.2",
"@storybook/addon-interactions": "^8.2.2",
"@storybook/addon-links": "^8.2.2",
Expand Down
7 changes: 6 additions & 1 deletion client/src/components/Design/components/Banner/Banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ const Banner = ({title, description, buttonText, onDelete, ...buttonProps}: Bann
cssProp={{borderRadius: '0.75rem'}}
>
<Flex gap="0.5rem">
<IconButton variants="none" onClick={onDelete} style={{display: 'flex', alignItems: 'flex-start'}}>
<IconButton
variants="none"
onClick={onDelete}
style={{display: 'flex', alignItems: 'flex-start'}}
aria-label="배너 닫기"
>
<Icon iconType="x" />
</IconButton>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {useTheme} from '@components/Design/theme/HDesignProvider';

import Text from '../Text/Text';
import Icon from '../Icon/Icon';
import IconButton from '../IconButton/IconButton';

import {chipButtonStyle} from './ChipButton.style';

Expand All @@ -16,10 +17,13 @@ interface Props {

const ChipButton = ({color, text, onClick}: Props) => {
const {theme} = useTheme();

return (
<div css={chipButtonStyle({color, theme})}>
<Text textColor="black">{text}</Text>
<Icon iconType="inputDelete" onClick={onClick} />
<IconButton variants="none" onClick={onClick} aria-label="인원 지우기">
<Icon iconType="inputDelete" />
</IconButton>
</div>
);
};
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 1843235

Please sign in to comment.