-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: interceptor http method도 지정하게 변경 #588
Open
kevstevie
wants to merge
2
commits into
BE/develop
Choose a base branch
from
BE/refactor/570
base: BE/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
backend/src/main/java/com/yigongil/backend/config/auth/path/HttpMethod.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.yigongil.backend.config.auth.path; | ||
|
||
public enum HttpMethod { | ||
|
||
PUT, | ||
POST, | ||
GET, | ||
PATCH, | ||
DELETE, | ||
ANY { | ||
@Override | ||
public boolean matches(String method) { | ||
return true; | ||
} | ||
}; | ||
|
||
public boolean matches(String method) { | ||
return name().equalsIgnoreCase(method); | ||
} | ||
} |
36 changes: 36 additions & 0 deletions
36
backend/src/main/java/com/yigongil/backend/config/auth/path/PathContainer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package com.yigongil.backend.config.auth.path; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
import java.util.Set; | ||
import org.springframework.util.AntPathMatcher; | ||
import org.springframework.util.PathMatcher; | ||
|
||
public class PathContainer { | ||
|
||
private final PathMatcher pathMatcher = new AntPathMatcher(); | ||
private final List<PathPattern> includedPaths = new ArrayList<>(); | ||
private final List<PathPattern> excludedPaths = new ArrayList<>(); | ||
|
||
public PathContainer excludePath(String path, HttpMethod... httpMethods) { | ||
excludedPaths.add(new PathPattern(path, Set.of(httpMethods))); | ||
|
||
return this; | ||
} | ||
|
||
public PathContainer includePath(String path, HttpMethod... httpMethods) { | ||
includedPaths.add(new PathPattern(path, Set.of(httpMethods))); | ||
|
||
return this; | ||
} | ||
|
||
public boolean isNotInclude(String path, String method) { | ||
boolean isExcludedPath = excludedPaths.stream() | ||
.anyMatch(pathPattern -> pathPattern.matches(pathMatcher, path, method)); | ||
|
||
boolean isNotIncludePath = includedPaths.stream() | ||
.noneMatch(pathPattern -> pathPattern.matches(pathMatcher, path, method)); | ||
|
||
return isExcludedPath || isNotIncludePath; | ||
} | ||
} |
39 changes: 39 additions & 0 deletions
39
backend/src/main/java/com/yigongil/backend/config/auth/path/PathInterceptor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
package com.yigongil.backend.config.auth.path; | ||
|
||
import javax.servlet.http.HttpServletRequest; | ||
import javax.servlet.http.HttpServletResponse; | ||
import org.springframework.web.servlet.HandlerInterceptor; | ||
|
||
public class PathInterceptor implements HandlerInterceptor { | ||
|
||
private final PathContainer pathContainer = new PathContainer(); | ||
private final HandlerInterceptor handlerInterceptor; | ||
|
||
public PathInterceptor(HandlerInterceptor handlerInterceptor) { | ||
this.handlerInterceptor = handlerInterceptor; | ||
} | ||
|
||
@Override | ||
public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler) throws Exception { | ||
String method = request.getMethod(); | ||
String uri = request.getRequestURI(); | ||
|
||
if (pathContainer.isNotInclude(uri, method)) { | ||
return true; | ||
} | ||
|
||
return handlerInterceptor.preHandle(request, response, handler); | ||
} | ||
|
||
public PathInterceptor includePath(String path, HttpMethod... methods) { | ||
pathContainer.includePath(path, methods); | ||
|
||
return this; | ||
} | ||
|
||
public PathInterceptor excludePath(String path, HttpMethod... methods) { | ||
pathContainer.excludePath(path, methods); | ||
|
||
return this; | ||
} | ||
} |
24 changes: 24 additions & 0 deletions
24
backend/src/main/java/com/yigongil/backend/config/auth/path/PathPattern.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package com.yigongil.backend.config.auth.path; | ||
|
||
import java.util.Set; | ||
import org.springframework.util.PathMatcher; | ||
|
||
public class PathPattern { | ||
|
||
private final String path; | ||
private final Set<HttpMethod> httpMethods; | ||
|
||
public PathPattern(String path, Set<HttpMethod> httpMethods) { | ||
this.path = path; | ||
this.httpMethods = httpMethods; | ||
} | ||
|
||
public boolean matches(PathMatcher pathMatcher, String targetPath, String pathMethod) { | ||
return pathMatcher.match(path, targetPath) && matchesMethod(pathMethod); | ||
} | ||
|
||
private boolean matchesMethod(String pathMethod) { | ||
return httpMethods.stream() | ||
.anyMatch(httpMethod -> httpMethod.matches(pathMethod)); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍