Fix/#547 킬링파트 여러 사용자 동시 좋아요 누를 때 동시성 이슈 해결 #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somsom13
requested review from
Cyma-s,
splitCoding and
seokhwan-an
as code owners
Cyma-s
approved these changes
Oct 28, 2023
Comment on lines
69
to
70
| final Optional<KillingPartLike> like = killingPart.findLikeByMember(member); | ||
| like.ifPresent(likeOnKillingPart -> { |
There was a problem hiding this comment.
하나로 묶는 거에 대해서는 어떻게 생각하세요?
Suggested change
| final Optional<KillingPartLike> like = killingPart.findLikeByMember(member); | |
| like.ifPresent(likeOnKillingPart -> { | |
| killingPart.findLikeByMember(member).ifPresent(likeOnKillingPart -> { |
There was a problem hiding this comment.
원래 그냥 if문으로 처리했다가 ifPresent로 바꾸면서 오 좋은데~~ 라고 생각했었는데,,, 이걸 하나로 줄일 생각은 또 왜 못했을까요?
감사합니다 eagle eye vero
| @@ -32,4 +33,12 @@ List<SongKillingPartKillingPartLikeCreatedAtDto> findLikedKillingPartAndSongByMe | |||
| + "FROM KillingPartLike kp_like " | |||
| + "WHERE kp_like.member=:member and kp_like.isDeleted=false") | |||
| List<Long> findLikedKillingPartIdsByMember(@Param("member") final Member member); | |||
|
|
|||
| @Query("update KillingPartLike kp_like set kp_like.isDeleted = false where kp_like.id = :id") | |||
| @Modifying(clearAutomatically = true, flushAutomatically = true) | |||
There was a problem hiding this comment.
부끄럽네요 (^///^) --<-<-<@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
킬링파트 여러 사용자 동시 좋아요 누를 때 동시성 이슈 해결
💬리뷰 참고사항
한 사용자가 여러 번 좋아요를 눌러서 좋아요가 동시에 도착하는 경우에 대해서는 처리가 되지 않습니다.
이미 프론트엔드 측에서 좋아요 버튼이 연속해서 눌리는 부분에 대해 처리가 되어있는 것으로 알고 있어서, 처리하지 않아도 무방할 것이라 생각했습니다. 이 부분에 대한 내용은 아래 링크를 참고해주세용!
https://somsom13.notion.site/36cd63ee0c5142e3be0a245d1c4e4928?pvs=4
#️⃣연관된 이슈
fix #547