refactor: if 문 메서드 분리

woowacourse-teams · Aug 9, 2023 · 7bd679a · 7bd679a
1 parent 2c5c53b
commit 7bd679a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/backend/src/main/java/shook/shook/song/application/dto/UnregisteredSongResponse.java b/backend/src/main/java/shook/shook/song/application/dto/UnregisteredSongResponse.java
@@ -19,8 +19,7 @@ public class UnregisteredSongResponse {
 
     public static UnregisteredSongResponse from(
         final SearchedSongFromManiaDBApiResponse searchedSongFromManiaDBApiResponse) {
-        if (searchedSongFromManiaDBApiResponse.getTrackArtists() == null
-            || searchedSongFromManiaDBApiResponse.getTrackArtists().getArtists() == null) {
+        if (isEmptyArtists(searchedSongFromManiaDBApiResponse)) {
             return new UnregisteredSongResponse(
                 searchedSongFromManiaDBApiResponse.getTitle().trim(),
                 EMPTY_SINGER,
@@ -37,6 +36,12 @@ public static UnregisteredSongResponse from(
         );
     }
 
+    private static boolean isEmptyArtists(
+        final SearchedSongFromManiaDBApiResponse searchedSongFromManiaDBApiResponse) {
+        return searchedSongFromManiaDBApiResponse.getTrackArtists() == null
+            || searchedSongFromManiaDBApiResponse.getTrackArtists().getArtists() == null;
+    }
+
     private static String collectToString(
         final SearchedSongFromManiaDBApiResponse searchedSongFromManiaDBApiResponse) {
         return searchedSongFromManiaDBApiResponse.getTrackArtists().getArtists().stream()