Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] refactor: 디자인 시스템 컴포넌트로 교체 #841

Merged
merged 5 commits into from
Nov 19, 2023

Conversation

hae-on
Copy link
Collaborator

@hae-on hae-on commented Nov 9, 2023

Issue

✨ 구현한 기능

디자인 시스템의 Carousel로 교체 했습니다.
디자인 시스템의 Input으로 교체 했습니다.
디자인 시스템의 Skeleton으로 교체 했습니다.
디자인 시스템의 Toast로 교체 했습니다.

📢 논의하고 싶은 내용

교체하고 local 돌렸을 때는 잘 나왔습니다.
배포해도 아마 잘 될 껄...??

🎸 기타

x

⏰ 일정

  • 추정 시간 : 1시간
  • 걸린 시간 : 30분

Copy link

github-actions bot commented Nov 9, 2023

Test Results

2 tests  ±0   2 ✔️ ±0   7s ⏱️ +7s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 57d40f2. ± Comparison against base commit a0793f3.

Copy link
Collaborator

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요 해옹~~~~

@@ -13,7 +13,7 @@
"test:coverage": "jest --watchAll --coverage"
},
"dependencies": {
"@fun-eat/design-system": "^0.3.18",
"@fun-eat/design-system": "^0.4.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우우우우우우우 👍

@hae-on hae-on merged commit 70f34f1 into develop Nov 19, 2023
1 check passed
@hae-on hae-on deleted the feat/issue-840 branch November 19, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 디자인 시스템 컴포넌트로 교체
2 participants