[FE] refactor: 무한스크롤 페이징 관련 api 변경 적용 #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leejin-Yang
approved these changes
Oct 18, 2023
| @@ -6,7 +6,7 @@ import type { ProductReviewResponse } from '@/types/response'; | |||
| const fetchProductReviews = async (pageParam: number, productId: number, sort: string) => { | |||
| const res = await productApi.get({ | |||
| params: `/${productId}/reviews`, | |||
| queries: `?sort=${sort}&page=${pageParam}`, | |||
| queries: `?sort=${sort}&lastReviewId=${pageParam}`, | |||
There was a problem hiding this comment.
넹 아래의 pageParam에서 초기값 0으로 설정하고 있습니다
Comment on lines
+23
to
+24
| const lastCursor = prevResponse.reviews.length ? prevResponse.reviews[prevResponse.reviews.length - 1].id : 0; | ||
| return prevResponse.hasNext ? lastCursor : undefined; |
xodms0309
added a commit
that referenced
this pull request
Oct 18, 2023
This reverts commit 9342c22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
page->lastProductId로 변경page->lastReviewId로 변경📢 논의하고 싶은 내용
x
🎸 기타
레시피의 경우 아직 구현이 안되었다고 합니다
⏰ 일정