[FE] 리뷰 삭제 기능 구현 #780
Merged
[FE] 리뷰 삭제 기능 구현 #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leejin-Yang
approved these changes
Oct 17, 2023
| const handleReviewDelete: MouseEventHandler<HTMLButtonElement> = (e) => { | ||
| e.preventDefault(); | ||
|
|
||
| const result = window.confirm('리뷰를 삭제하시겠습니까?'); |
| const { reviewId, productName, content, rating, favoriteCount } = review; | ||
|
|
||
| const handleReviewDelete: MouseEventHandler<HTMLButtonElement> = (e) => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
클릭이벤트에 어떤 동작을 막기 위해 썼나요? 궁금합니다!
There was a problem hiding this comment.
그 리뷰를 클릭하면 리뷰 상세페이지로 이동하는게 그거 막으려고 썼습니다!
There was a problem hiding this comment.
리스트에 링크가 있군요..! 좋습니다 👍
|
|
||
| interface MemberReviewItemProps { | ||
| review: MemberReview; | ||
| isMemberPage: boolean; |
There was a problem hiding this comment.
회원 리뷰면 이 prop은 없어도 될거 같아요!
There was a problem hiding this comment.
이게 마이페이지에서 리뷰 전체 목록을 눌렀을 때만 삭제 아이콘이 뜨게끔 하기 위해서 저 prop을 추가한거에요! 만약 네이밍이 헷갈리다면 isMemberReviewListPage 이런식으로 바꿀까요??
There was a problem hiding this comment.
타미 의견도 좋고 미리보기를 기준으로 한다면 isPreview도 괜찮아보여요.!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
x
⏰ 일정