Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] feat: 꿀조합 댓글이 없는 경우 예외처리 #772

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[FE] feat: 꿀조합 댓글이 없는 경우 예외처리 #772

merged 2 commits into from
Oct 16, 2023

Conversation

xodms0309
Copy link
Collaborator

@xodms0309 xodms0309 commented Oct 16, 2023 •
edited
Loading

Issue

✨ 구현한 기능

  • getNextPageParam에서 id를 접근하지 못하는 경우 처리
  • ui에서도 댓글이 없을 때 텍스트 처리

📢 논의하고 싶은 내용

x

🎸 기타

x

⏰ 일정

  • 추정 시간 : 10분
  • 걸린 시간 : 10분

@xodms0309 xodms0309 self-assigned this Oct 16, 2023
@github-actions
Copy link

Test Results

2 tests   2 ✔️  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit bdc7fcd.

hae-on
hae-on approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 설명 잘들었습니다 어푸르브~

Leejin-Yang
Leejin-Yang approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@xodms0309 xodms0309 merged commit be83c6b into develop Oct 16, 2023
3 checks passed
@xodms0309 xodms0309 deleted the feat/issue-771 branch October 16, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hae-on hae-on hae-on approved these changes

@Leejin-Yang Leejin-Yang Leejin-Yang approved these changes

Assignees

@xodms0309 xodms0309

Labels
🐛 Bug 🔑 FE ✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] 꿀조합 댓글이 없는 경우 예외처리
3 participants
@xodms0309 @Leejin-Yang @hae-on