Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] feat: 랭킹 기준 텍스트 추가 #765

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[FE] feat: 랭킹 기준 텍스트 추가 #765

merged 4 commits into from
Oct 16, 2023

Conversation

Leejin-Yang
Copy link
Collaborator

Issue

✨ 구현한 기능

  • 각 랭킹 선정 기준 설명 추가
  • 상품 목록, 상세 평점 소수 한자리까지로 수정

📢 논의하고 싶은 내용
스크린샷 2023-10-14 오후 5 09 20 스크린샷 2023-10-14 오후 5 09 28

스크린샷 2023-10-14 오후 5 10 54

🎸 기타

  • 랭킹 업데이트 기준 한 줄로 요약하기 어렵더라구요. 우선 단톡방에 올라온 것을 기준으로 작성했습니다.
  • 다른 랭킹과 같이 상품 랭킹의 이모지를 수정했습니다. 의견 주세요!

⏰ 일정

  • 추정 시간 : 2시간
  • 걸린 시간 : 30분

@Leejin-Yang Leejin-Yang self-assigned this Oct 14, 2023
@github-actions
Copy link

github-actions bot commented Oct 14, 2023 •
edited
Loading

Test Results

2 tests   2 ✔️  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit a843884.

♻️ This comment has been updated with latest results.

@hae-on
Copy link
Collaborator

hae-on commented Oct 14, 2023

앞에 i에 동그라미 쳐져 있는 아이콘 붙이는거 어떤가요?!?!

@Leejin-Yang
Copy link
Collaborator Author

Leejin-Yang commented Oct 14, 2023 •
edited
Loading

@hae-on

좋습니다~!
svg 추가해서 수정했습니다

스크린샷 2023-10-14 오후 7 57 54

hae-on
hae-on approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

죻습니다.
다만 약간 염려되는건 '알고리즘'이라는 말이 좀 걸리긴 하네요.
요즘 유튜브 때문에 알고리즘이라는 말이 통용되기는해도
일반인에게 막 와닿는 개념은 아니라,,,

일단은 이렇게 진행하되 나중에 더 생각해보면 좋을 것 같네요!
수고하셨습니다.

xodms0309
xodms0309 approved these changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@xodms0309 xodms0309 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿! 수고하셧ㅅ브니다
아 그리고 피알 제목에 feat 붙여주세요 ㅋㅋㅋ

frontend/src/components/Common/Svg/SvgSprite.tsx
@@ -77,6 +77,9 @@ const SvgSprite = () => {
<symbol id="plane" viewBox="0 0 256 256">
<path d="M232 127.89a16 16 0 0 1-8.18 14L55.91 237.9A16.14 16.14 0 0 1 48 240a16 16 0 0 1-15.05-21.34l27.35-79.95a4 4 0 0 1 3.79-2.71H136a8 8 0 0 0 8-8.53a8.19 8.19 0 0 0-8.26-7.47H64.16a4 4 0 0 1-3.79-2.7l-27.44-80a16 16 0 0 1 22.92-19.23l168 95.89a16 16 0 0 1 8.15 13.93Z" />
</symbol>
<symbol id="info" viewBox="0 0 16 16">
<path d="M8 7a.5.5 0 0 1 .5.5v3a.5.5 0 0 1-1 0v-3A.5.5 0 0 1 8 7zm0-.75a.749.749 0 1 0 0-1.5.749.749 0 0 0 0 1.498zM2 8a6 6 0 1 1 12 0A6 6 0 0 1 2 8zm6-5a5 5 0 1 0 0 10A5 5 0 0 0 8 3z" />
</symbol>
</svg>
);
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storybook preview-body.html에도 추가해주세요~~

@Leejin-Yang Leejin-Yang changed the title [FE] 랭킹 기준 텍스트 추가 [FE] feat: 랭킹 기준 텍스트 추가 Oct 15, 2023
@Leejin-Yang Leejin-Yang merged commit 62124a6 into develop Oct 16, 2023
3 checks passed
@Leejin-Yang Leejin-Yang deleted the feat/issue-761 branch October 16, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hae-on hae-on hae-on approved these changes

@xodms0309 xodms0309 xodms0309 approved these changes

Assignees

@Leejin-Yang Leejin-Yang

Labels
🔑 FE 🎨 UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] 랭킹 기준 텍스트 추가
3 participants
@Leejin-Yang @hae-on @xodms0309