Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] refactor: 상품 랭킹 알고리즘 개선 #756

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Conversation

Go-Jaecheol
Copy link
Collaborator

Issue

✨ 구현한 기능

  • 상품 랭킹 조회 시 기간 설정
    • 기간 : 최근 2주
    @Query("SELECT new com.funeat.product.dto.ProductReviewCountDto(p, COUNT(r.id)) "
              + "FROM Product p "
              + "LEFT JOIN Review r ON r.product.id = p.id "
              + "WHERE p.averageRating > 3.0 "
              + "AND r.createdAt BETWEEN :startDateTime AND :endDateTime "
              + "GROUP BY p.id")
    List<ProductReviewCountDto> findAllByAverageRatingGreaterThan3(final LocalDateTime startDateTime, final LocalDateTime endDateTime);
    # 추가된 구문
    AND r.createdAt BETWEEN :startDateTime AND :endDateTime

📢 논의하고 싶은 내용

X

🎸 기타

X

⏰ 일정

  • 추정 시간 : 1h
  • 걸린 시간 : 1h

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Test Results

274 tests   274 ✔️  21s ⏱️
136 suites      0 💤
136 files        0

Results for commit 7a49e6a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 도메인 랭킹 관련 구현하셔서 너무 고생 많으셨습니다 ㅠㅠ👍
나머지는 다 괜찮은데 정렬 설정 한번만 확인 부탁드려요!

Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 간단한 변경사항 말고는 없습니다~ 고생하셨어요~

Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드디어 우리의 상품 랭킹이 백종원 제육한판에서 벗어날 수 있겠군요ㅎㅎㅎ
고생하셨습니다 망고!

@Go-Jaecheol Go-Jaecheol merged commit 87c5ac8 into develop Oct 18, 2023
3 checks passed
@Go-Jaecheol Go-Jaecheol deleted the feat/issue-753 branch October 18, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] 상품 랭킹 알고리즘 개선
4 participants