Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] refactor: 꿀조합 랭킹 알고리즘 개선 #755

Merged
merged 8 commits into from
Oct 18, 2023
Merged

[BE] refactor: 꿀조합 랭킹 알고리즘 개선 #755

merged 8 commits into from
Oct 18, 2023

Conversation

Go-Jaecheol
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol commented Oct 12, 2023 •
edited
Loading

Issue

✨ 구현한 기능

  • 시간에 대한 가중치 추가

    $$ Score = \frac{RecipeFavorite}{(age + 1)^{gravity}} $$

    • age : 현재 시간 - 리뷰 작성 시간 (ChronoUnit.DAYS.between으로 비교해서 day 단위)
    • gravity : 시간에 대한 중력 상수 (높을 수록 시간이 지남에 따라 급격하게 점수 낮아짐) => 0.1로 선정
      • 0.1 (좋아요 10개 & 14일 ~= 좋아요 9개 & 7일)

📢 논의하고 싶은 내용

X

🎸 기타

⏰ 일정

  • 추정 시간 : 1.5h
  • 걸린 시간 : 1h

@Go-Jaecheol Go-Jaecheol self-assigned this Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Test Results

273 tests   273 ✔️  25s ⏱️
136 suites      0 💤
136 files        0 ❌

Results for commit 474d6ee.

♻️ This comment has been updated with latest results.

wugawuga
wugawuga reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요 망고!!
코멘트 한번 확인 부탁드려요 ㅎㅎㅎ

backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/main/java/com/funeat/recipe/persistence/RecipeRepository.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/persistence/RecipeRepositoryTest.java Outdated Show resolved Hide resolved
70825
70825 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 우가 피드백 말고는 코멘트 남길게 없는 것 같아요 ~
고생하셨어요~

backend/src/main/java/com/funeat/recipe/application/RecipeService.java Show resolved Hide resolved
hanueleee
hanueleee reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~
저 랭킹 점수 구하는 식은 볼 때마다 신기하네요 굿굿

backend/src/main/java/com/funeat/recipe/domain/Recipe.java Show resolved Hide resolved
wugawuga
wugawuga approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

랭킹 마스터 망고 고생하셨어요 🙇‍♂️

@Go-Jaecheol Go-Jaecheol merged commit 0532bbe into develop Oct 18, 2023
3 checks passed
@Go-Jaecheol Go-Jaecheol deleted the feat/issue-740 branch October 18, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanueleee hanueleee hanueleee approved these changes

@wugawuga wugawuga wugawuga approved these changes

@70825 70825 70825 approved these changes

Assignees

@Go-Jaecheol Go-Jaecheol

Labels
🔒 BE 🔧 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 꿀조합 랭킹 알고리즘 개선
4 participants
@Go-Jaecheol @70825 @wugawuga @hanueleee