[FE] feat: 라우팅 관련 처리 #752
Merged
[FE] feat: 라우팅 관련 처리 #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hae-on
approved these changes
Oct 12, 2023
xodms0309
reviewed
Oct 13, 2023
| }; | ||
| }; | ||
|
|
||
| export default useLocalStorage; |
There was a problem hiding this comment.
React의 hooks를 사용하지 않으니 custom hook 말고 util로 분리해도 되지 않을까요?
특히 setLocalStorage라는 함수가 useLocalStorage에서 사용된다면 setState 함수로 오해할 수도 있을 것 같아요
Comment on lines
8
to
10
| } catch (error) { | ||
| return item; | ||
| } |
There was a problem hiding this comment.
에러 났을 때 왜 item을 return하는건가요?! 궁금..
There was a problem hiding this comment.
json 메서드 실행 에러를 잡아주는 친구입니다
만약 문자열을 저장했다면 에러 발생하고 catch로 가서 문자열 그대로를 반환하는 느낌??
|
로컬스토리지 로직 유틸함수로 이동했습니다. 확인해주세요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
x
🎸 기타
⏰ 일정