[FE] feat: 꿀조합 댓글 기능 구현 #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leejin-Yang
reviewed
Oct 12, 2023
| setCommentValue(e.target.value); | ||
| }; | ||
|
|
||
| const handleSubmitComment: FormEventHandler<HTMLFormElement> = async (e) => { |
| { | ||
| onSuccess: () => { | ||
| setCommentValue(''); | ||
| toast.success('댓글이 등록되었습니다.'); |
| return ( | ||
| <> | ||
| <CommentInputForm onSubmit={handleSubmitComment}> | ||
| <Input |
There was a problem hiding this comment.
200자면 Input으로 했을 때 내용이 다 보이지 않을거 같아서 Textarea가 좋아보이는데 어떻게 생각하시나요??
| </Heading> | ||
| <Spacing size={12} /> | ||
| {recipeComments.map((comment) => ( | ||
| <CommentItem key={comment.id} comment={comment} /> |
There was a problem hiding this comment.
List 컴포넌트를 만들어서 Suspense 적용하는건 어떻게 생각하시나요??
hae-on
reviewed
Oct 12, 2023
| }, | ||
| onError: (error) => { | ||
| if (error instanceof Error) { | ||
| alert(error.message); |
| </SubmitButton> | ||
| </CommentInputForm> | ||
| <Text size="xs" color={theme.textColors.info} align="right"> | ||
| {commentValue.length} / {MAX_COMMENT_LENGTH} |
There was a problem hiding this comment.
스크린리더를 위해 '자'를 넣어주세요!
{commentValue.length}자 / {MAX_COMMENT_LENGTH}자
|
@hae-on @Leejin-Yang |
Leejin-Yang
reviewed
Oct 12, 2023
|
|
||
| const MAX_COMMENT_LENGTH = 200; | ||
|
|
||
| const CommentForm = ({ recipeId }: CommentFormProps) => { |
| }; | ||
|
|
||
| const useRecipeCommentQuery = (recipeId: number) => { | ||
| return useSuspendedQuery(['recipeComment', recipeId], () => fetchRecipeComments(recipeId)); |
Comment on lines
76
to
84
| <Heading as="h3" size="lg"> | ||
| 댓글 ({recipeComments.length}개) | ||
| </Heading> | ||
| <Spacing size={12} /> | ||
| <ErrorBoundary fallback={ErrorComponent} handleReset={reset}> | ||
| <Suspense fallback={<Loading />}> | ||
| <CommentList comments={recipeComments} /> | ||
| </Suspense> | ||
| </ErrorBoundary> |
There was a problem hiding this comment.
하나를 말해도 열을 아는 천재 타미
파이팅! 👍
|
@hae-on @Leejin-Yang 
|
hae-on
reviewed
Oct 12, 2023
| @@ -27,7 +27,7 @@ type ToastStyleProps = Pick<ToastProps, 'isError'> & { isAnimating?: boolean }; | |||
|
|
|||
| const ToastWrapper = styled.div<ToastStyleProps>` | |||
| position: relative; | |||
| width: 100%; | |||
| width: calc(100% - 20px); | |||
Leejin-Yang
approved these changes
Oct 13, 2023
Comment on lines
+16
to
+17
| const { fetchNextPage, hasNextPage, data } = useInfiniteRecipeCommentQuery(Number(recipeId)); | ||
| useIntersectionObserver<HTMLDivElement>(fetchNextPage, scrollRef, hasNextPage); |
|
|
||
| import { SvgIcon } from '@/components/Common'; | ||
| import { useToastActionContext } from '@/hooks/context'; | ||
| import useRecipeCommentMutation from '@/hooks/queries/recipe/useRecipeCommentMutation'; |
Comment on lines
+26
to
+30
| getNextPageParam: (prevResponse: CommentResponse) => { | ||
| const lastId = prevResponse.comments[prevResponse.comments.length - 1].id; | ||
| const totalElements = prevResponse.totalElements; | ||
| const lastCursor = { lastId: lastId, totalElements: totalElements }; | ||
| return prevResponse.hasNext ? lastCursor : undefined; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
x
🎸 기타
x
⏰ 일정