[FE] feat: Skeleton UI 추가 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leejin-Yang
reviewed
Sep 21, 2023
| @@ -81,6 +81,7 @@ export default HomePage; | |||
|
|
|||
| const Banner = styled.img` | |||
| width: 100%; | |||
| height: auto; | |||
There was a problem hiding this comment.
Banner 컴포넌트에 height 추가해주세요~
360입니다
Leejin-Yang
approved these changes
Sep 21, 2023
Comment on lines
22
to
28
| <ProductImage | ||
| src={image} | ||
| width={90} | ||
| height={90} | ||
| alt={`${name}사진`} | ||
| onLoad={() => setIsImageLoading(false)} | ||
| /> |
There was a problem hiding this comment.
리스트에 쓰이는 이미지에 loading='lazy' 넣어주세요.! 배너는 지연 로딩 없어도 될듯 맨위에 있어서
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
x
🎸 기타
x
⏰ 일정