Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALL] Github Actions workflows 버전 관리 #668

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[ALL] Github Actions workflows 버전 관리 #668

merged 2 commits into from
Sep 19, 2023

Conversation

70825
Copy link
Member

@70825 70825 commented Sep 19, 2023

Issue

✨ 구현한 기능

  • 회의한 내용대로 노드 20 버전이 필요한 버전까지 안올렸습니다.
    • [올라간 버전]
    • EnricoMi/publish-unit-test-result-action@v1EnricoMi/publish-unit-test-result-action@v2
  • 참고 (노드 20 버전으로 업데이트할 때)
    • [공통]
    • actions/checkout@v3actions/checkout@v4
    • mikepenz/action-junit-report@v3mikepenz/action-junit-report@v4
    • [프론트]
    • node-version: '18.16.1'node-version: '20.x.x' (그때 버전에 맞게 수정)
    • [기타]
    • 시간이 지나면 나중에 다른 곳들도 버전이 올라갈 수도 있음

actions/checkout@v4의 경우엔 현재 노드 20 미만의 버전을 지원하지 않는다고 합니다 (참고)

📢 논의하고 싶은 내용

-x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 : 0.5
  • 걸린 시간 : 1

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Test Results

224 tests   224 ✔️  14s ⏱️
112 suites      0 💤
112 files        0

Results for commit 1a9f626.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼한 로건!!! LGTM~👍

Copy link
Collaborator

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귯!

Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve~~!

@70825 70825 merged commit 66a2147 into develop Sep 19, 2023
@70825 70825 deleted the feat/issue-651 branch September 19, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ALL] GitHub Actions workflows 버전 관리
4 participants