[FE] refactor: scrollTop에서 ref로 접근하는 방식으로 변경 #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leejin-Yang
reviewed
Sep 15, 2023
| @@ -1,8 +1,8 @@ | |||
| import type { RefObject } from 'react'; | |||
|
|
|||
| const useScroll = () => { | |||
There was a problem hiding this comment.
훅의 인자로 ref를 받는건 어떤가요??
Leejin-Yang
approved these changes
Sep 15, 2023
| }, 100); | ||
| if (ref.current) { | ||
| const timeout = setTimeout(() => { | ||
| ref.current?.scrollIntoView({ behavior: 'smooth' }); |
There was a problem hiding this comment.
? 삭제해주세요 ㅎㅎ 제가 안 지웠음 ㅎㅎㅎ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
x
🎸 기타
x
⏰ 일정